FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(Odiff): this.hddService.generateNewImage is not a function by mokhtardziri · Pull Request #357 · Visual-Regression-Tracker/backend · GitHub

/ backend Public

fix(Odiff): this.hddService.generateNewImage is not a function - #357

Open
mokhtardziri wants to merge 5 commits into
Visual-Regression-Tracker:masterfrom
mokhtardziri:customizations
ConversationCommits (5)ChecksFiles changed
Open

fix(Odiff): this.hddService.generateNewImage is not a function#357
mokhtardziri wants to merge 5 commits into
Visual-Regression-Tracker:masterfrom
mokhtardziri:customizations

Conversation

mokhtardziri commented Jul 28, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown

Summary by CodeRabbit

  • Improvements

    • Improved image handling for saving, reading, copying, and deleting files.
    • Added validation to prevent invalid or unsafe image paths.
    • Improved handling of missing images and image data retrieval.
    • Enhanced reliability of image comparisons and related services.

  • Tests

    • Updated test coverage and setup for improved service reliability.

mokhtardziri reopened this Jul 28, 2026

coderabbitai Bot commented Jul 28, 2026 •
edited
Loading

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info ⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 17b00e9e-22e4-4c0b-af90-0fca1ea45634

📥 Commits

Reviewing files that changed from the base of the PR and between d689cbc and 42c1de4.

📒 Files selected for processing (1)
  • src/static/hdd/hdd.service.ts

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

Walkthrough

HddService now uses asynchronous filesystem operations, validates image paths, and supports buffer retrieval and image copying. StaticModule exports the service, and OdiffService receives it through dependency injection with an updated test mock.

Changes

HddService and OdiffService integration

Layer / File(s) Summary
HddService filesystem operations
src/static/hdd/hdd.service.ts		 HddService validates image paths and uses promise-based APIs for saving, reading, copying, and deleting images. Image decoding is separated from buffer retrieval.
HddService module wiring
src/static/static.module.ts		 StaticModule registers and exports HddService.
OdiffService injection integration
src/compare/libs/odiff/odiff.service.ts, src/compare/libs/odiff/odiff.service.spec.ts		 OdiffService injects HddService directly. The test module provides a mocked HddService and uses updated relative imports.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 42c1d

The PR fixes HDD-backed image comparison wiring without introducing an actionable correctness or security risk; no merge-blocking risk remains after normal checks and review.

Suggested reviewers: pashidlos, ngervasyuk

🚥 Pre-merge checks | ✅ 5 ✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: fixing the OdiffService dependency on HddService that caused generateNewImage to be unavailable.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

✨ Finishing Touches 🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

pashidlos approved these changes Jul 28, 2026
View reviewed changes

pashidlos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM!

mokhtardziri requested a review from pashidlos August 16, 2026 14:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

pashidlos Awaiting requested review from pashidlos

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL