[wasm-emscripten-finalize] Remove --no-legalize-javascript-ffi flag - #9016
Merged
sbc100 merged 1 commit intoAug 20, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Maybe we should add a CHANGELOG.md entry if this can break users? |
Sorry, something went wrong.
stevenfontanella
approved these changes
Aug 19, 2026
stevenfontanella
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM after CI passes
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
This is an extremely emscripten-specific tool, so there is really is only one user. |
Sorry, something went wrong.
kripken
approved these changes
Aug 19, 2026
This flag was redundant given that we have `--bigint`. See emscripten-core/emscripten#27570 for where we stop using it in emscripten.
sbc100
force-pushed
the
remove_finalize_flag
branch
from
32849b2 to
12d185c
Compare
August 19, 2026 22:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This flag was redundant given that we have --bigint. See emscripten-core/emscripten#27570 for where we stop using it in emscripten.