I64ToI32Lowering: Document non-trapping float truncation behavior. NFC - #9022
Merged
sbc100 merged 1 commit intoAug 19, 2026
Merged
I64ToI32Lowering: Document non-trapping float truncation behavior. NFC#9022sbc100 merged 1 commit into
sbc100 merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
tlively
approved these changes
Aug 19, 2026
… (NFC) Document that `I64ToI32Lowering` is designed for the `wasm2js` pipeline and does not preserve strict WebAssembly trapping semantics for float-to-int conversions. Also add comments in `lowerTruncFloatToInt` noting that the emitted 32-bit truncations are translated to JavaScript bitwise operations in `wasm2js` and thus do not trap on out-of-range values, NaN, or infinity. See: #9017
sbc100
force-pushed
the
i64-lowering-comments
branch
from
343791a to
de0d99f
Compare
August 19, 2026 22:18
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
kripken
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document that I64ToI32Lowering is designed for the wasm2js pipeline and does not preserve strict WebAssembly trapping semantics for float-to-int conversions.
Also add comments in lowerTruncFloatToInt noting that the emitted 32-bit truncations are translated to JavaScript bitwise operations in wasm2js and thus do not trap on out-of-range values, NaN, or infinity.
See: #9017