FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Skip animations with non-default parameters for v3.0 by camillobruni · Pull Request #291 · WebKit/JetStream · GitHub

/ JetStream Public

Skip animations with non-default parameters for v3.0 - #291

Merged
camillobruni merged 5 commits into
WebKit:JetStream3.0from
camillobruni:2026-03-05_no_animation
Mar 5, 2026
ConversationCommits (5)ChecksFiles changed
Merged

Skip animations with non-default parameters for v3.0#291
camillobruni merged 5 commits into
WebKit:JetStream3.0from
camillobruni:2026-03-05_no_animation

Conversation

camillobruni commented Mar 5, 2026

Copy link
Copy Markdown
Contributor

We don't want CSS animation to interfere with short running measurements which
can easaily happen if you only run a single workload.

netlify Bot commented Mar 5, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for webkit-jetstream-preview ready!

Name Link
🔨 Latest commit 4fd7d5b
🔍 Latest deploy log https://app.netlify.com/projects/webkit-jetstream-preview/deploys/69aa142659984e00082aef72
😎 Deploy Preview https://deploy-preview-291--webkit-jetstream-preview.netlify.app
📱 Preview on mobile Toggle QR Code...



Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

camillobruni mentioned this pull request Mar 5, 2026
Open
camillobruni changed the title Skip animations with non-default parameters Skip animations with non-default parameters for v3.0 Mar 5, 2026
camillobruni requested review from danleh and kmiller68 March 5, 2026 16:02
danleh approved these changes Mar 5, 2026
View reviewed changes

danleh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, but wouldn't we also want to disable animations for the full suite via an additional parameter?

camillobruni requested a review from danleh March 5, 2026 16:14

camillobruni commented Mar 5, 2026

Copy link
Copy Markdown
Contributor Author

For now this is probably good enough since you can disable it with "&startAutomtically" which we can use in our infra.
I'll finish the more involved approach in #200 where we can just wait for the animation to finish in all other cases.

danleh approved these changes Mar 5, 2026
View reviewed changes

danleh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Still LGTM, but let's have a look by Keith whether this would be fine for 3.0.

kmiller68 approved these changes Mar 5, 2026
View reviewed changes

kmiller68 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, have you had a chance to confirm on your end that it doesn't change the scores? My local testing of Safari in our harness was neutral.

Comment thread index.html Outdated

camillobruni commented Mar 5, 2026

Copy link
Copy Markdown
Contributor Author

On chrome running on the local server I see no diff with the default params:

Before                               196.1  ± 1.1%
After                                196.18 ± 0.48%

camillobruni merged commit cdc22d4 into WebKit:JetStream3.0 Mar 5, 2026
4 checks passed
camillobruni deleted the 2026-03-05_no_animation branch March 5, 2026 23:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

kmiller68 kmiller68 approved these changes
danleh danleh approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL