| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Previously the measure plugin's volume tool collapsed cut and fill into
a single absolute number (abs of the signed sum), discarding the sign
information needed to distinguish material above vs. below the
interpolated base surface. It also always sampled dsm.tif regardless
of which raster layer (DSM/DTM) was active on the map when the
measurement was drawn.
- calc_volume() now returns {cut, fill, net} instead of one scalar.
fill = material above the base surface, cut = material below it,
net = fill - cut (signed).
- TaskVolume now accepts a dem_type ("dsm"/"dtm") parameter and reads
the corresponding asset, validating the matching extent exists.
- MeasurePopup now reads the clicked layer's meta.type to determine
which model to request, sends it along with the volume request, and
displays which model (Surface/Terrain) plus Cut/Fill/Net in the
flyout and GeoJSON export properties.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Error messages under 200 chars (e.g. a raw file-not-found path from calc_volume) had no word-wrap rule and no whitespace to break on, so they spilled outside the popup instead of wrapping. The .long class only added scroll/max-height past the 200-char threshold, which doesn't address horizontal overflow of an unbroken token like a filesystem path. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Can you show one or two screenshots showing your UI changes and explain how did you test to verify this implementation is correct? |
Sorry, something went wrong.
Sorry, something went wrong.
|
Thanks for the screenshots and explanation of your dataset. But how did you verify that the output numbers are correct? (Do you understand the changes AI has written? How do you know they are correct?) As an implementation note, you don't want the program to pick a default surface, you want to know if there are multiple surfaces available (none, DSM, DTM, DSM+DTM ?) under the area of the polygon (but remember, there could be multiple tasks in Project View!), if you have more than one surface then display a selector (defaulting to DSM). Please do not simply copy paste this into an AI though; it does not help to just prompt additions to WebODM (I can do that too and it takes me 2 seconds). The real work is in validating these changes and testing (and if you can do that, then it helps, but if you can't, let's leave this as a "proof of concept"). 🙏 |
Sorry, something went wrong.
|
So I do have at least some programming experience and, yes, I understand the changes that AI has written. You have given me some direction and I will keep working on it as I find time and in the meantime I have changed this pr to a draft. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
The measure plugin previously calculated volume as the absolute value of the sum of cut and fill. It also incorrectly used the Digital Surface Model data for this calculation, even when the user had selected DTM as the visible layer.
Now the Measure results show
summary of changes to files:
MeasurePopup now determines which model to use and sends it with the volume call. it also displays all of the new information listed above.
dem_type parameter ("dim"/"dtm") was added to TaskVolume, which verifies that the resource exists and sends it with the calc_volume call.
calc_volume now calculates and returns cut, fill and net individually