After the introduction of viperHTML.adoptable = true, capable of creating a compact and compression friendly way to delimit all interpolations of a template literals, hyperHTML would like to re-introduce this ability lost wtih v2 release because unstable.
All the basics are working but there are still two cases I cannot code cover because failing:
nodes with just textContent behaves differently, when text action is used the adoption shuold work properly
when there are levels outside those already explored, findNode(...) internal function does not handle well the level variable together with the index
Once these two outstanding bugs are fixed, I will think about releasing v3 to include adopt within the library and branch out v2 for eventual emergency fixes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the introduction of viperHTML.adoptable = true, capable of creating a compact and compression friendly way to delimit all interpolations of a template literals, hyperHTML would like to re-introduce this ability lost wtih v2 release because unstable.
All the basics are working but there are still two cases I cannot code cover because failing:
Once these two outstanding bugs are fixed, I will think about releasing v3 to include adopt within the library and branch out v2 for eventual emergency fixes.