FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

hyperHTML.adopt(liveNode) by WebReflection · Pull Request #185 · WebReflection/hyperHTML · GitHub

hyperHTML.adopt(liveNode) - #185

Open
WebReflection wants to merge 3 commits into
masterfrom
re-adopt
Open

hyperHTML.adopt(liveNode)#185
WebReflection wants to merge 3 commits into
masterfrom
re-adopt

Conversation

WebReflection commented Feb 5, 2018
edited
Loading

Copy link
Copy Markdown
Owner

After the introduction of viperHTML.adoptable = true, capable of creating a compact and compression friendly way to delimit all interpolations of a template literals, hyperHTML would like to re-introduce this ability lost wtih v2 release because unstable.

All the basics are working but there are still two cases I cannot code cover because failing:

  • nodes with just textContent behaves differently, when text action is used the adoption shuold work properly
  • when there are levels outside those already explored, findNode(...) internal function does not handle well the level variable together with the index

Once these two outstanding bugs are fixed, I will think about releasing v3 to include adopt within the library and branch out v2 for eventual emergency fixes.

WebReflection self-assigned this Feb 5, 2018
WebReflection mentioned this pull request Feb 5, 2018

Copy link
Copy Markdown

Coverage remained the same at ?% when pulling 4f1d747 on re-adopt into c689e81 on master.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL