Fix support for type 'E' multiple response sets in SPSS SAV files - #347
Open
slobodan-ilic wants to merge 6 commits into
Open
Fix support for type 'E' multiple response sets in SPSS SAV files#347slobodan-ilic wants to merge 6 commits into
slobodan-ilic wants to merge 6 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
slobodan-ilic
force-pushed
the
issue-346-support-type-e-mr-sets
branch
from
e415fd5 to
aee63b2
Compare
October 1, 2025 06:56
slobodan-ilic
force-pushed
the
issue-346-support-type-e-mr-sets
branch
from
a4159ed to
7acc0df
Compare
October 18, 2025 13:36
Replace //IGNORE with EILSEQ handling in readstat_convert(). Invalid bytes now show as '?' instead of causing failures.
evanmiller
reviewed
Oct 25, 2025
Comment thread
src/readstat_convert.c
| * This handles files with encoding errors more gracefully | ||
| * than failing completely. */ | ||
| if (src_len > 0 && dst_left > 0) { | ||
| *dst_end++ = '?'; |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Hi @slobodan-ilic Thanks for your PR, could you resolve the conflicts and review comments to make this continue? ❤This is a good implement for multiple response. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #346
Description
This PR adds support for type 'E' multiple response sets in SPSS SAV files. These are dichotomies with CATEGORYLABELS=COUNTEDVALUES and appear in subtype 19 records in addition to the already supported subtype 7.
Changes
Testing
I've tested the changes with files containing type 'E' multiple response sets, and they are now correctly parsed.