FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

UI: Use `__next40pxDefaultSize` for buttons consistently by yogeshbhutkar · Pull Request #702 · WordPress/ai · GitHub

/ ai Public

UI: Use __next40pxDefaultSize for buttons consistently - #702

Merged
dkotter merged 3 commits into
WordPress:developfrom
yogeshbhutkar:fix/update-default-button-size
Jun 17, 2026
ConversationCommits (3)ChecksFiles changed
Merged

UI: Use __next40pxDefaultSize for buttons consistently#702
dkotter merged 3 commits into
WordPress:developfrom
yogeshbhutkar:fix/update-default-button-size

Conversation

yogeshbhutkar commented Jun 11, 2026 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

What, Why, and How?

Closes #701

This PR standardizes button sizing across the plugin UI by opting default Button usages into the WordPress Components 40px default size.

It also:

  • Enables the @wordpress/components-no-missing-40px-size-prop ESLint rule.
  • Adds __next40pxDefaultSize to default button usages.
  • Marks intentional smaller controls with size="small".
  • Makes the “Generate Meta Description” button span the full available width for consistency with similar sidebar actions.

Use of AI Tools

AI assistance: No

Screenshots

Before After

Note: Above is a minor subset of the total buttons addressed in this PR.

yogeshbhutkar marked this pull request as ready for review June 11, 2026 12:16

github-actions Bot commented Jun 11, 2026 •
edited
Loading

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: yogeshbhutkar <yogeshbhutkar@git.wordpress.org>
Co-authored-by: dkotter <dkotter@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

dkotter requested changes Jun 11, 2026
View reviewed changes

dkotter left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Code wise this looks good to me, need to fully test the UI to ensure this all looks good. But there is a merge conflict that needs resolved first

dkotter added this to the 1.2.0 milestone Jun 11, 2026
yogeshbhutkar force-pushed the fix/update-default-button-size branch from 6766c5c to 91c65d8 Compare June 11, 2026 16:45
yogeshbhutkar requested a review from dkotter June 11, 2026 17:08
yogeshbhutkar force-pushed the fix/update-default-button-size branch from 91c65d8 to b348c05 Compare June 12, 2026 08:10
dkotter mentioned this pull request Jun 15, 2026
Closed
yogeshbhutkar force-pushed the fix/update-default-button-size branch from b348c05 to 529d6bb Compare June 16, 2026 11:42
dkotter modified the milestones: 1.2.0, 1.1.0 Jun 17, 2026
dkotter merged commit f0e23c7 into WordPress:develop Jun 17, 2026
22 checks passed
yogeshbhutkar deleted the fix/update-default-button-size branch June 18, 2026 03:07
jorgefilipecosta pushed a commit that referenced this pull request Jun 29, 2026
UI: Use __next40pxDefaultSize for buttons consistently (#702)
c421403 
Changed - Use `__next40pxDefaultSize` for buttons consistently.

Co-authored-by: yogeshbhutkar <yogeshbhutkar@git.wordpress.org>
Co-authored-by: dkotter <dkotter@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dkotter dkotter approved these changes

Assignees

yogeshbhutkar

Labels

None yet

Projects

None yet

Milestone

1.1.0

Development

Successfully merging this pull request may close these issues.

UI: Inconsistent button sizing

2 participants

Back | FazBrowse Home | New Git URL