FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Remove unnecessary question marks from checkbox labels by tillkruss · Pull Request #110 · WordPress/performance · GitHub

Remove unnecessary question marks from checkbox labels - #110

Merged
aristath merged 2 commits into
trunkfrom
fix/remove-module-questionmark
Jan 20, 2022
Merged

Remove unnecessary question marks from checkbox labels#110
aristath merged 2 commits into
trunkfrom
fix/remove-module-questionmark

Conversation

tillkruss commented Jan 19, 2022
edited
Loading

Copy link
Copy Markdown
Member

Summary

It's not really common to add a question mark to checkboxes, in WordPress or elsewhere.

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

tillkruss added [Type] Enhancement A suggestion for improvement of an existing feature Infrastructure Issues for the overall performance plugin infrastructure labels Jan 19, 2022
tillkruss added this to the 1.0.0-beta.1 milestone Jan 19, 2022
tillkruss requested a review from felixarntz as a code owner January 19, 2022 20:48

felixarntz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM!

Preferably we should have an issue for PRs, but this is so simple it should be fine. Alternatively it could be a follow-up PR to #30. But all good :)

aristath merged commit 50d740d into trunk Jan 20, 2022
aristath deleted the fix/remove-module-questionmark branch January 20, 2022 09:50
felixarntz changed the title Update load.php Remove unnecessary question marks in checkbox labels Jan 28, 2022
felixarntz changed the title Remove unnecessary question marks in checkbox labels Remove unnecessary question marks from checkbox labels Jan 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Infrastructure Issues for the overall performance plugin infrastructure [Type] Enhancement A suggestion for improvement of an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL