FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add Site Health check module for persistent object cache by tillkruss · Pull Request #111 · WordPress/performance · GitHub

/ performance Public

Add Site Health check module for persistent object cache - #111

Merged
felixarntz merged 48 commits into
trunkfrom
feature/objectcache-health
Feb 28, 2022
ConversationCommits (48)ChecksFiles changed
Merged

Add Site Health check module for persistent object cache#111
felixarntz merged 48 commits into
trunkfrom
feature/objectcache-health

Conversation

tillkruss commented Jan 19, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Summary

This PR adds the object-cache/health module containing a single health check to suggest the usage of a persistent object cache backend, if needed.

The module adds the direct persistent_object_cache health check.

  • Plugins (like WooCommerce) can use the site_status_suggest_persistent_object_cache filter to inject their own criteria checks to suggest the use of an object cache, as well as bypass the default core health check
  • Hosts may use the site_status_persistent_object_cache_url filter to link to their own support docs
  • Hosts may want to use the site_status_persistent_object_cache_notes filter to recommend their preferred object caching solution
  • Plugin authors may want to append notes using the site_status_persistent_object_cache_notes filter on why object caching is recommended for their plugin

Resolves #35.

tillkruss added [Type] Feature A new feature within an existing module [Focus] Object Cache Needs Discussion Anything that needs a discussion/agreement labels Jan 19, 2022
tillkruss added this to the 1.0.0-beta.1 milestone Jan 19, 2022
tillkruss self-assigned this Jan 19, 2022
tillkruss changed the title initial code import Object Cache health check Jan 19, 2022
eclarke1 removed the Needs Discussion Anything that needs a discussion/agreement label Jan 20, 2022
eugene-manuilov reviewed Jan 21, 2022
View reviewed changes
Comment thread modules/object-cache/health/load.php
Comment thread modules/object-cache/health/load.php
Comment thread modules/object-cache/health/load.php Outdated
Comment thread modules/object-cache/health/load.php Outdated
spacedmonkey reviewed Feb 8, 2022
View reviewed changes
Comment thread modules/object-cache/health/load.php Outdated
spacedmonkey reviewed Feb 8, 2022
View reviewed changes
Comment thread modules/object-cache/health/load.php Outdated
spacedmonkey reviewed Feb 8, 2022
View reviewed changes
Comment thread modules/object-cache/health/load.php Outdated
spacedmonkey reviewed Feb 8, 2022
View reviewed changes
Comment thread modules/object-cache/health/load.php Outdated
spacedmonkey reviewed Feb 8, 2022
View reviewed changes
Comment thread modules/object-cache/health/load.php Outdated
spacedmonkey reviewed Feb 8, 2022
View reviewed changes
Comment thread modules/object-cache/health/load.php Outdated

spacedmonkey commented Feb 8, 2022

Copy link
Copy Markdown
Member

@tillkruss Can you explain what I am meant to see in site health. I checked two sites and I see any new options in site health?

Can you provide details to test this and maybe a screenshot?

felixarntz reviewed Feb 25, 2022
View reviewed changes

felixarntz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@tillkruss LGTM, just a few last nit-picks.

Comment thread modules/object-cache/persistent-object-cache-health-check/load.php
Comment thread modules/object-cache/persistent-object-cache-health-check/load.php Outdated
Comment thread modules/object-cache/persistent-object-cache-health-check/load.php Outdated
tillkruss and others added 3 commits February 26, 2022 13:49
Update modules/object-cache/persistent-object-cache-health-check/load…
a83ae10 
….php

Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
Update modules/object-cache/persistent-object-cache-health-check/load…
fb4e749 
….php

Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
Update modules/object-cache/persistent-object-cache-health-check/load…
fd07b49 
….php

Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>

tillkruss commented Feb 26, 2022

Copy link
Copy Markdown
Member Author

@felixarntz: All done. Any filter you'd like me to remove?

spacedmonkey approved these changes Feb 28, 2022
View reviewed changes

spacedmonkey left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Good first PR.

felixarntz reviewed Feb 28, 2022
View reviewed changes

felixarntz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@tillkruss I think all filters currently present make sense, except for the one I'm flagging below. Particularly the filters to modify the Site Health contents are great to have.

If you feel strongly about keeping this filter, I'd say at a minimum we should put that into the perflab_oc_health_should_persistent_object_cache() function as a "short-circuit" filter, rather than hooking that function onto the filter.

Comment thread modules/object-cache/persistent-object-cache-health-check/load.php Outdated
Comment thread modules/object-cache/persistent-object-cache-health-check/load.php
felixarntz reviewed Feb 28, 2022
View reviewed changes

felixarntz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@tillkruss Production code lgtm, leaving a few recommendations on tests. At a minimum, we should fix the one filter usage there that's using the wrong filter.

Comment thread tests/modules/object-cache/persistent-object-cache-health-check/health-check-test.php Outdated
Comment thread tests/modules/object-cache/persistent-object-cache-health-check/health-check-test.php Outdated
Comment thread tests/modules/object-cache/persistent-object-cache-health-check/health-check-test.php Outdated
Comment thread modules/object-cache/persistent-object-cache-health-check/load.php Outdated
tillkruss and others added 2 commits February 28, 2022 12:13
Update modules/object-cache/persistent-object-cache-health-check/load…
badede0 
….php

Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
simplify tests
6291513

tillkruss commented Feb 28, 2022 •
edited
Loading

Copy link
Copy Markdown
Member Author

@tillkruss Production code lgtm, leaving a few recommendations on tests. At a minimum, we should fix the one filter usage there that's using the wrong filter.

@felixarntz: All resolved in 6291513.

felixarntz approved these changes Feb 28, 2022
View reviewed changes

felixarntz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@tillkruss Awesome stuff! 🎉

felixarntz changed the title Object Cache health check Add Site Health check module for persistent object cache Feb 28, 2022
felixarntz merged commit c655588 into trunk Feb 28, 2022
tillkruss mentioned this pull request Mar 1, 2022
Merged
3 tasks
tillkruss deleted the feature/objectcache-health branch March 7, 2022 19:27
tillkruss mentioned this pull request Apr 14, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

eugene-manuilov eugene-manuilov left review comments
pbearne pbearne approved these changes
spacedmonkey spacedmonkey approved these changes
felixarntz felixarntz approved these changes

Assignees

tillkruss

Labels

[Type] Feature A new feature within an existing module

Projects

None yet

Milestone

1.0.0-beta.1

Development

Successfully merging this pull request may close these issues.

Promote object caching in Site Health

6 participants

Back | FazBrowse Home | New Git URL