FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Improve message for WebP site health test by the-hercules · Pull Request #1249 · WordPress/performance · GitHub

/ performance Public

Improve message for WebP site health test - #1249

Merged
westonruter merged 6 commits into
WordPress:trunkfrom
the-hercules:feat-webp-support-message
Jun 12, 2024
ConversationCommits (6)ChecksFiles changed
Merged

Improve message for WebP site health test#1249
westonruter merged 6 commits into
WordPress:trunkfrom
the-hercules:feat-webp-support-message

Conversation

the-hercules commented May 26, 2024 •
edited by westonruter
Loading

Copy link
Copy Markdown
Contributor

Fixes #715

Summary

Updated error message in the WordPress performance plugin regarding WebP image support. The message now informs users that WebP images require support from the web server's image processing libraries (Imagick or LibGD) and provides guidance on checking supported file formats.

the-hercules commented May 26, 2024

Copy link
Copy Markdown
Contributor Author

@thelovekesh Some checks are failing due to missing labels, can you add labels to this PR?

mukeshpanchal27 added [Plugin] Modern Image Formats Issues for the Modern Image Formats plugin (formerly WebP Uploads) no milestone PRs that do not have a defined milestone for release [Type] Enhancement A suggestion for improvement of an existing feature labels May 27, 2024
the-hercules marked this pull request as ready for review May 27, 2024 06:19

github-actions Bot commented May 27, 2024 •
edited
Loading

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @hercules@herculess-MacBook-Air.local, @aashish.sharma@rtcamp.com.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: hercules@herculess-MacBook-Air.local, aashish.sharma@rtcamp.com.

Co-authored-by: the-hercules <thehercules@git.wordpress.org>
Co-authored-by: mukeshpanchal27 <mukesh27@git.wordpress.org>
Co-authored-by: joemcgill <joemcgill@git.wordpress.org>
Co-authored-by: westonruter <westonruter@git.wordpress.org>
Co-authored-by: adamsilverstein <adamsilverstein@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

thelovekesh requested a review from joemcgill May 27, 2024 06:25
mukeshpanchal27 requested changes May 27, 2024
View reviewed changes

mukeshpanchal27 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for the PR. The link should be clickable.

westonruter removed the no milestone PRs that do not have a defined milestone for release label May 28, 2024
westonruter added [Plugin] Performance Lab Issue relates to work in the Performance Lab Plugin only and removed [Plugin] Modern Image Formats Issues for the Modern Image Formats plugin (formerly WebP Uploads) labels May 28, 2024
joemcgill requested changes May 30, 2024
View reviewed changes

joemcgill left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Prior to merging these changes, I think we need to consider whether the updated text addresses the issue. See #715 (comment).

westonruter commented Jun 4, 2024

Copy link
Copy Markdown
Member

@the-hercules new suggested text from @adamsilverstein in #715 (comment)

the-hercules commented Jun 6, 2024

Copy link
Copy Markdown
Contributor Author

@westonruter does this message looks good ?

WebP support can only be enabled by your hosting provider. Please contact them to inquire about switching to a plan that supports WebP, or consider switching to a host that offers this feature. For more information about WebP image support for WordPress sites, please Learn more here.

westonruter commented Jun 6, 2024

Copy link
Copy Markdown
Member

For more information about WebP image support for WordPress sites, please Learn more here.

I would phrase this rather as:

Learn more about WebP image support for WordPress sites.

I'll defer to @adamsilverstein for the ultimate wording.

adamsilverstein commented Jun 6, 2024

Copy link
Copy Markdown
Member

Looks good, including suggestion from @westonruter

westonruter approved these changes Jun 6, 2024
View reviewed changes

westonruter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, with a possible improved word choice.

Comment thread plugins/performance-lab/includes/site-health/webp-support/helper.php Outdated
westonruter changed the title fix: Update WebP not Supported message Improve message for WebP site health test Jun 7, 2024
the-hercules requested a review from joemcgill June 7, 2024 08:51

the-hercules commented Jun 7, 2024

Copy link
Copy Markdown
Contributor Author

@mukeshpanchal27 @joemcgill Awaiting Review, I have made the suggested Changes.

the-hercules commented Jun 12, 2024

Copy link
Copy Markdown
Contributor Author

Hey @joemcgill , Could you please review this PR.

westonruter merged commit 31c6ee9 into WordPress:trunk Jun 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

westonruter westonruter approved these changes
mukeshpanchal27 mukeshpanchal27 approved these changes
adamsilverstein Awaiting requested review from adamsilverstein adamsilverstein is a code owner
joemcgill Awaiting requested review from joemcgill

Assignees

No one assigned

Labels

[Plugin] Performance Lab Issue relates to work in the Performance Lab Plugin only [Type] Enhancement A suggestion for improvement of an existing feature

Projects

None yet

Milestone

performance-lab 3.3.0

Development

Successfully merging this pull request may close these issues.

Enhance the health check message when WebP is not supported

5 participants

Back | FazBrowse Home | New Git URL