Fix disabled options from reappearing in Site Health after external update - #1374
Merged
mukeshpanchal27 merged 11 commits intoJul 26, 2024
Merged
Fix disabled options from reappearing in Site Health after external update#1374mukeshpanchal27 merged 11 commits into
mukeshpanchal27 merged 11 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
mukeshpanchal27
marked this pull request as ready for review
July 18, 2024 06:40
Copy link
Copy Markdown
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. Co-authored-by: mukeshpanchal27 <mukesh27@git.wordpress.org> Co-authored-by: swissspidy <swissspidy@git.wordpress.org> Co-authored-by: westonruter <westonruter@git.wordpress.org> Co-authored-by: adamsilverstein <adamsilverstein@git.wordpress.org> Co-authored-by: joemcgill <joemcgill@git.wordpress.org> To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Sorry, something went wrong.
mukeshpanchal27
requested review from
adamsilverstein,
joemcgill,
swissspidy and
westonruter
July 18, 2024 06:41
swissspidy
reviewed
Jul 18, 2024
Comment thread
...ce-lab/tests/includes/site-health/audit-autoloaded-options/test-audit-autoloaded-options.php
Outdated
swissspidy
reviewed
Jul 18, 2024
Comment thread
...ce-lab/tests/includes/site-health/audit-autoloaded-options/test-audit-autoloaded-options.php
Outdated
westonruter
reviewed
Jul 18, 2024
Comment thread
...ce-lab/tests/includes/site-health/audit-autoloaded-options/test-audit-autoloaded-options.php
Outdated
westonruter
reviewed
Jul 18, 2024
Comment thread
plugins/performance-lab/includes/site-health/audit-autoloaded-options/helper.php
Outdated
westonruter
reviewed
Jul 18, 2024
westonruter
reviewed
Jul 18, 2024
Comment thread
plugins/performance-lab/includes/site-health/audit-autoloaded-options/helper.php
Outdated
westonruter
reviewed
Jul 18, 2024
Comment thread
plugins/performance-lab/includes/site-health/audit-autoloaded-options/helper.php
Outdated
westonruter
reviewed
Jul 18, 2024
Comment thread
plugins/performance-lab/includes/site-health/audit-autoloaded-options/helper.php
Outdated
Co-authored-by: Weston Ruter <westonruter@google.com>
westonruter
reviewed
Jul 23, 2024
Comment thread
plugins/performance-lab/includes/site-health/audit-autoloaded-options/helper.php
Outdated
westonruter
reviewed
Jul 24, 2024
Co-authored-by: Weston Ruter <westonruter@google.com>
Copy link
Copy Markdown
Member
Author
|
Thanks @westonruter for the feedback. PR ready for review. |
Sorry, something went wrong.
westonruter
approved these changes
Jul 25, 2024
westonruter
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
adamsilverstein
approved these changes
Jul 25, 2024
adamsilverstein
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Fantastic
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1340