FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add release documentation by JustinyAhin · Pull Request #138 · WordPress/performance · GitHub

/ performance Public

Add release documentation - #138

Merged
JustinyAhin merged 13 commits into
trunkfrom
add/131-release-documentation
Feb 4, 2022
ConversationCommits (13)ChecksFiles changed
Merged

Add release documentation#138
JustinyAhin merged 13 commits into
trunkfrom
add/131-release-documentation

Conversation

JustinyAhin commented Jan 31, 2022

Copy link
Copy Markdown
Member

Summary

This PR adds a new file Releasing-the-plugin.md with the release steps.

Fixes #131.

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

JustinyAhin added [Type] Documentation Documentation to be added or enhanced Infrastructure Issues for the overall performance plugin infrastructure labels Jan 31, 2022
JustinyAhin added this to the 1.0.0-beta.1 milestone Jan 31, 2022

JustinyAhin commented Jan 31, 2022 •
edited
Loading

Copy link
Copy Markdown
Member Author

@felixarntz @jeffpaul here is a draft for the release doc. There are still details to add, but I want us to agree on what's included before.

For now, here what the structure looks like:

  • Update version number
    • package.json
    • load.php
    • readme.txt
  • Update readme.txt
    • npm run readme -- -m "version"
  • Create a new GitHub release
  • ...

Any other things we should include/change?

felixarntz reviewed Jan 31, 2022
View reviewed changes

felixarntz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@JustinyAhin This is a good start, however I think there are a few things missing, and IMO it would be worth clarifying a couple things in more depth, particularly around the branches to use and also to keep other maintainers up to date on the process.

I've added a couple suggestions, let me know your thoughts.

Comment thread docs/Releasing-the-plugin.md Outdated
Comment thread docs/Releasing-the-plugin.md
Comment thread docs/Releasing-the-plugin.md Outdated
Comment thread docs/Releasing-the-plugin.md
Comment thread docs/Releasing-the-plugin.md
Comment thread docs/Releasing-the-plugin.md Outdated
Comment thread docs/Releasing-the-plugin.md Outdated
Comment thread docs/Releasing-the-plugin.md Outdated
JustinyAhin and others added 8 commits January 31, 2022 13:22
Add section for module headers fields translation
5419b35 
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
Add additional details to the readme.txt update section
2354a7f 
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
Update docs/Releasing-the-plugin.md
0bf431b 
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
Update docs/Releasing-the-plugin.md
f664668 
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
Add details about changing next occurences to the release version n…
e5e5b18 
…umber

Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
Update docs/Releasing-the-plugin.md
a12e051 
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
Update release publishing section
8eb003f 
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
Update Releasing-the-plugin.md
7b08402

JustinyAhin commented Jan 31, 2022

Copy link
Copy Markdown
Member Author

I've added a couple suggestions, let me know your thoughts.

@felixarntz thanks for looking. All your suggestions make sense. I've committed them to the PR and added a small change.

JustinyAhin marked this pull request as ready for review January 31, 2022 12:42
eclarke1 requested a review from felixarntz February 3, 2022 14:04
felixarntz mentioned this pull request Feb 3, 2022
Closed
felixarntz approved these changes Feb 3, 2022
View reviewed changes

felixarntz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@JustinyAhin Thank you, lgtm! I just added one more comment for your consideration, but it's not critical.

Comment thread docs/Releasing-the-plugin.md Outdated
Update docs/Releasing-the-plugin.md
5380ce5 
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
JustinyAhin merged commit 3195f38 into trunk Feb 4, 2022
tillkruss deleted the add/131-release-documentation branch March 7, 2022 19:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

felixarntz felixarntz approved these changes

Assignees

No one assigned

Labels

Infrastructure Issues for the overall performance plugin infrastructure [Type] Documentation Documentation to be added or enhanced

Projects

None yet

Milestone

1.0.0-beta.1

Development

Successfully merging this pull request may close these issues.

Add release documentation

3 participants

Back | FazBrowse Home | New Git URL