| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
it's nice to see the output But most users won't know what to look for |
Sorry, something went wrong.
|
@pbearne Can you look at the screenshot again? Earlier I added a screenshot in the last line to indicate where I copied the code of checking WebP support from, but I saw how it can be mistaken as the output of the code, so I have uploaded the actual screenshot of output. Do you still feel we need to show percentage-wise support? I think now since the user has a clear picture to see that they have an action to take here, I feel we don't need to show partial support indication. |
Sorry, something went wrong.
Co-authored-by: Crisoforo Gaspar Hernández <hello@crisoforo.com>
…tangajjar/performance into feature/130-webp-support-site-health
There was a problem hiding this comment.
This looks good to me, let's wait on other people to chime in case they have any additional feedback.
Thank you for putting this together 🥇 🙇
Sorry, something went wrong.
|
I wouldn't call it critical. Kick it down to recommendations. |
Sorry, something went wrong.
|
Nice work @kirtangajjar - code looks good, I'll give this a test. |
Sorry, something went wrong.
|
This worked well in my testing! After testing though, I feel like the notice belongs under "recommended improvements" instead of "critical issues". Having WebP support is nice to have, it isn't really critical. |
Sorry, something went wrong.
Co-authored-by: Adam Silverstein <adamsilverstein@earthboundhosting.com>
|
@adamsilverstein Done. LMK if you find any additional changes. |
Sorry, something went wrong.
Co-authored-by: Adam Silverstein <adamsilverstein@earthboundhosting.com>
|
@kirtangajjar I left one additional tiny suggestion on the text, then we can merge this. Thanks for your work here! |
Sorry, something went wrong.
|
@adamsilverstein I've committed your suggestion. Thanks for giving it a second look! |
Sorry, something went wrong.
|
👍🏼 Looks good, nice work @kirtangajjar - going to go ahead and merge this. We'll get another chance to review the exact wording when we propose this feature for core. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Summary
Fixes #130.
Relevant technical choices
Adds a module in site health to check for WebP support and shows a warning if support is not present.
If either GD or Imagick has WebP support, the WebP support warning is not shown.
The code of checking support in GD and Imagick is same as how it's shown in site health info's media handling section.
Screenshots