Only store info for relevant standalone plugins in the transient cache - #1573
Only store info for relevant standalone plugins in the transient cache#1573mukeshpanchal27 merged 2 commits into
Conversation
Sorry, something went wrong.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. Co-authored-by: mukeshpanchal27 <mukesh27@git.wordpress.org> Co-authored-by: swissspidy <swissspidy@git.wordpress.org> Co-authored-by: adamsilverstein <adamsilverstein@git.wordpress.org> Co-authored-by: felixarntz <flixos90@git.wordpress.org> To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Sorry, something went wrong.
adamsilverstein
left a comment
There was a problem hiding this comment.
Nice!
Sorry, something went wrong.
felixarntz
left a comment
There was a problem hiding this comment.
@mukeshpanchal27 Great catch!
PR looks good, though one recommendation to improve performance.
Sorry, something went wrong.
|
FYI: We forgot to account for plugin dependencies here. Follow-up PR: #1613 |
Sorry, something went wrong.
Follow-up on #1562
The current API query https://api.wordpress.org/plugins/info/1.2/?action=query_plugins&request[author]=wordpressdotorg&request[tag]=performance&request[per_page]=100 is returning some unrelated plugins like Plugin Check (PCP) and SQLite Database Integration. In the future, if anyone else uses Performance as a tag, it will also be added to our transient. However, we only need the standalone plugins defined in perflab_get_standalone_plugin_data().
I’ve also moved the array definition for $fields after the cache check, as it's redundant in the cached version.