Here's a script you can use to update the snapshots once the actual.html files have been generated:

#!/bin/bash
for actual in $( find . -name 'actual.html' ); do
	expected=${actual/actual/expected};
	echo "$actual => $expected"
	mv "$actual" "$expected"
done

There should probably be something like this added to scripts in package.json.

Here's a script you can use to update the snapshots once the actual.html files have been generated:

#!/bin/bash
for actual in $( find . -name 'actual.html' ); do
	expected=${actual/actual/expected};
	echo "$actual => $expected"
	mv "$actual" "$expected"
done

There should probably be something like this added to scripts in package.json.

Hello @westonruter I didn't get your above message. Is this for updating PHP unit tests ?

Yes, the unit test failures are due to the HTML snapshots being out for date now that the media query is updated. So you need to move all the actual.html files generated during the unit tests over to replace the expected.html (if indeed the changes are as expected!) That bash script is a way to do so in bulk.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.86%. Comparing base (5a1e472) to head (4c01373).
Report is 16 commits behind head on trunk.

@@            Coverage Diff             @@
##            trunk    #1833      +/-   ##
==========================================
+ Coverage   65.82%   65.86%   +0.03%     
==========================================
  Files          88       88              
  Lines        6865     6873       +8     
==========================================
+ Hits         4519     4527       +8     
  Misses       2346     2346              

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: SohamPatel46 <sohampate1@git.wordpress.org>
Co-authored-by: westonruter <westonruter@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

I'm just realizing that this isn't going to solve the potential sub-pixel rendering issue. Look at this diff:

Note that min-width: 481px and 481px < width are identical in behavior. Only the syntax is different. For there to be any change in behavior the new syntax would need to change to 480px < width, so decrementing the minimum bound by one.

See correction below: #1833 (comment)

Note that min-width: 481px and 481px < width are identical in behavior. Only the syntax is different. For there to be any change in behavior the new syntax would need to change to 480px < width, so decrementing the minimum bound by one.

Correction: they aren't actually identical in behavior. In the min-width: 481px syntax, the viewport width can be exactly 481px whereas in the new syntax it can never be exactly 481px since it must be greater. So this means the result is worse. This emphasizes the need to somehow have this output 480px < width.

The od_generate_media_query() function may need to have the semantics of its parameters changed, so that it is understood somehow the passed $minimum_viewport_width is not inclusive meaning that the viewport can never exactly equal that minimum width but it can be greater than it. In contrast, the $maximum_viewport_width is inclusive, in that the viewport width can exactly equal the max.

This may end up going down a rabbit hole because the URL Metric Groups have minimum and maximum viewport widths too, so then their semantics would probably need to change as well.

This will take some more thought.

Take a look at #1839.

@felixarntz Please take a look when you get a chance.