FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Enable all non-experimental modules on plugin activation by kirtangajjar · Pull Request #191 · WordPress/performance · GitHub

/ performance Public

Enable all non-experimental modules on plugin activation - #191

Merged
felixarntz merged 5 commits into
WordPress:trunkfrom
kirtangajjar:feature/default-module-activation
Mar 2, 2022
ConversationCommits (5)ChecksFiles changed
Merged

Enable all non-experimental modules on plugin activation#191
felixarntz merged 5 commits into
WordPress:trunkfrom
kirtangajjar:feature/default-module-activation

Conversation

kirtangajjar commented Feb 28, 2022

Copy link
Copy Markdown
Member

Summary

Fixes #61. Enable all non-experimental modules on plugin activation.

Fix is quiet simple so there isn't much to explain here.

kirtangajjar commented Feb 28, 2022

Copy link
Copy Markdown
Member Author

@eclarke1 Can you please add "Needs Review" and other relevant labels as well?

felixarntz added [Type] Enhancement A suggestion for improvement of an existing feature Infrastructure Issues for the overall performance plugin infrastructure labels Feb 28, 2022
kirtangajjar mentioned this pull request Feb 28, 2022
Closed
felixarntz added this to the 1.0.0-beta.1 milestone Feb 28, 2022
felixarntz added [Type] Enhancement A suggestion for improvement of an existing feature and removed [Type] Enhancement A suggestion for improvement of an existing feature labels Feb 28, 2022
felixarntz reviewed Feb 28, 2022
View reviewed changes

felixarntz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@kirtangajjar This looks like a solid start. I left a few comments and suggestions for parts that need iteration.

Comment thread admin/load.php Outdated
Comment thread admin/load.php
Comment thread admin/load.php Outdated
felixarntz approved these changes Feb 28, 2022
View reviewed changes

felixarntz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@kirtangajjar I've added those few requested changes and with that this looks good to me. Thank you for the PR! 🎉

mitogh reviewed Feb 28, 2022
View reviewed changes

mitogh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Overall looks great, few minor comments.

Comment thread admin/load.php
Comment thread admin/load.php
Update admin/load.php
f80fdac 
Bail if option is set with existing value

Co-authored-by: Crisoforo Gaspar Hernández <hello@crisoforo.com>

kirtangajjar commented Mar 1, 2022

Copy link
Copy Markdown
Member Author

Thank you @felixarntz @mitogh for your reviews. I have committed the suggestion made by @mitogh. Please do let me know incase this needs something else from my end :)

felixarntz commented Mar 1, 2022

Copy link
Copy Markdown
Member

@kirtangajjar Sorry, see my comment in #191 (comment), I'm not sure that change actually makes sense. From what I can tell it was better the way you originally had it:

  • We want to only run our logic if the option is not set.
  • But now after the change suggested by @mitogh the logic is also run if the option is set to e.g. an empty array.
  • The latter is problematic since it would mean we may override the user-defined configuration just because they disabled all modules, which is unexpected UX.

felixarntz requested changes Mar 1, 2022
View reviewed changes

felixarntz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@kirtangajjar One thing remaining here per the above.

cc @mitogh

Comment thread admin/load.php
Update admin/load.php
d8495cc 
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
kirtangajjar requested a review from felixarntz March 2, 2022 14:03

kirtangajjar commented Mar 2, 2022

Copy link
Copy Markdown
Member Author

@felixarntz Fixed. Sorry didn't think that one through fully.

felixarntz approved these changes Mar 2, 2022
View reviewed changes

felixarntz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you @kirtangajjar for the PR - awesome work! 🙌

felixarntz merged commit b483ca7 into WordPress:trunk Mar 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

felixarntz felixarntz approved these changes
mitogh mitogh approved these changes
adamsilverstein Awaiting requested review from adamsilverstein
JustinyAhin Awaiting requested review from JustinyAhin
tillkruss Awaiting requested review from tillkruss
ThierryA Awaiting requested review from ThierryA

Assignees

No one assigned

Labels

Infrastructure Issues for the overall performance plugin infrastructure [Type] Enhancement A suggestion for improvement of an existing feature

Projects

None yet

Milestone

1.0.0-beta.1

Development

Successfully merging this pull request may close these issues.

Define default module activation (onboarding)

4 participants

Back | FazBrowse Home | New Git URL