Use original image to generate all additional image format sub-sizes - #207
Merged
felixarntz merged 13 commits intoMar 14, 2022
Merged
Use original image to generate all additional image format sub-sizes#207felixarntz merged 13 commits into
felixarntz merged 13 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
For all the generated sub-sizes use the original image instead of the attached image in order to accurate replicate the same process that WordPress uses to create each sub-size.
The removal of the `preg_replace` as is not required due we are using the original image, and the original image does not have a custom suffix.
felixarntz
reviewed
Mar 8, 2022
felixarntz
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
@mitogh Mostly looks good, I left a few comments.
The one critical thing we need to add here is about considering the orientation and applying the rotation as needed, similar to how WP core does.
Sorry, something went wrong.
Comment thread
modules/images/webp-uploads/load.php
Outdated
Comment thread
modules/images/webp-uploads/load.php
Outdated
Comment thread
modules/images/webp-uploads/load.php
Outdated
Comment thread
modules/images/webp-uploads/load.php
Outdated
felixarntz
approved these changes
Mar 14, 2022
felixarntz
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Great work @mitogh!
Sorry, something went wrong.
Comment thread
tests/modules/images/webp-uploads/webp-uploads-test.php
Outdated
adamsilverstein
self-requested a review
March 14, 2022 21:30
adamsilverstein
requested changes
Mar 14, 2022
adamsilverstein
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Excellent! Left one tiny typo correction.
Sorry, something went wrong.
adamsilverstein
approved these changes
Mar 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #204
Relevant technical choices
When creating all the sub-sizes for additional mime types, using the original image instead of the attached image would ensure that all additional sub-sizes have the same size as the original images.
Checklist