FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Select MIME type to use in frontend content based on file size by jjgrainger · Pull Request #243 · WordPress/performance · GitHub

/ performance Public

Select MIME type to use in frontend content based on file size - #243

Merged
mitogh merged 10 commits into
trunkfrom
feature/186-select-smaller-image-size-from-sources-update
Mar 31, 2022
ConversationCommits (10)ChecksFiles changed
Merged

Select MIME type to use in frontend content based on file size#243
mitogh merged 10 commits into
trunkfrom
feature/186-select-smaller-image-size-from-sources-update

Conversation

jjgrainger commented Mar 21, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

Fixes #186

Relevant technical choices

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

jjgrainger requested a review from mitogh March 21, 2022 11:10
jjgrainger self-assigned this Mar 21, 2022
jjgrainger added [Type] Enhancement A suggestion for improvement of an existing feature [Focus] Images no milestone PRs that do not have a defined milestone for release labels Mar 21, 2022
jjgrainger changed the title Feature/186 select smaller image size from sources update Select smaller image size from sources update Mar 21, 2022
jjgrainger mentioned this pull request Mar 21, 2022
Closed
3 tasks
jjgrainger marked this pull request as ready for review March 21, 2022 16:30
mitogh reviewed Mar 21, 2022
View reviewed changes
Comment thread modules/images/webp-uploads/load.php Outdated
Comment thread modules/images/webp-uploads/load.php Outdated
Comment thread modules/images/webp-uploads/load.php Outdated
jjgrainger mentioned this pull request Mar 22, 2022
Closed
eugene-manuilov requested changes Mar 22, 2022
View reviewed changes

eugene-manuilov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Mostly looks good to me. Added a few comments with a few nitpicks, nothing major. Also, do we need to target this PR against the release/1.0.0-beta.x branch?

Comment thread modules/images/webp-uploads/load.php Outdated
Comment thread modules/images/webp-uploads/load.php Outdated
Comment thread modules/images/webp-uploads/load.php Outdated
Comment thread modules/images/webp-uploads/load.php Outdated

jjgrainger commented Mar 23, 2022

Copy link
Copy Markdown
Contributor Author

Mostly looks good to me. Added a few comments with a few nitpicks, nothing major. Also, do we need to target this PR against the release/1.0.0-beta.x branch?

I agree, though not sure which release branch it should target? There are currently 3.

eugene-manuilov requested changes Mar 23, 2022
View reviewed changes

eugene-manuilov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Almost looks good to me. Just added a few nitpicks.

Comment thread modules/images/webp-uploads/load.php Outdated
Comment thread modules/images/webp-uploads/load.php Outdated
Comment thread modules/images/webp-uploads/load.php Outdated
mitogh reviewed Mar 23, 2022
View reviewed changes

mitogh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Great work, just some minor suggestions / questions.

Comment thread tests/modules/images/webp-uploads/webp-uploads-test.php Outdated
Comment thread tests/modules/images/webp-uploads/webp-uploads-test.php
Comment thread tests/modules/images/webp-uploads/webp-uploads-test.php Outdated
Comment thread tests/modules/images/webp-uploads/webp-uploads-test.php
Comment thread tests/modules/images/webp-uploads/webp-uploads-test.php Outdated
jjgrainger changed the base branch from trunk to release/1.0.0-rc.1 March 30, 2022 11:07
jjgrainger requested a review from felixarntz as a code owner March 30, 2022 11:13
mitogh changed the base branch from release/1.0.0-rc.1 to trunk March 30, 2022 16:27
mitogh added this to the 1.0.0 milestone Mar 31, 2022
mitogh removed the no milestone PRs that do not have a defined milestone for release label Mar 31, 2022
mitogh merged commit 7930608 into trunk Mar 31, 2022
mitogh deleted the feature/186-select-smaller-image-size-from-sources-update branch March 31, 2022 23:59
felixarntz changed the title Select smaller image size from sources update Select MIME type to use in frontend based on file size Apr 18, 2022
felixarntz changed the title Select MIME type to use in frontend based on file size Select MIME type to use in frontend content based on file size Apr 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

eugene-manuilov eugene-manuilov approved these changes
mitogh mitogh approved these changes
adamsilverstein Awaiting requested review from adamsilverstein
getsource Awaiting requested review from getsource
felixarntz Awaiting requested review from felixarntz

Assignees

jjgrainger

Labels

[Type] Enhancement A suggestion for improvement of an existing feature

Projects

None yet

Milestone

1.0.0

Development

Successfully merging this pull request may close these issues.

Select the smaller image size from the list of available sources

3 participants

Back | FazBrowse Home | New Git URL