Select image editor based on WebP support instead of always using the default one - #259
Merged
mitogh merged 3 commits intoMar 24, 2022
Merged
Select image editor based on WebP support instead of always using the default one#259mitogh merged 3 commits into
mitogh merged 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
By doing so we are able to perform all the logic when replacing an editor and using an image editor with support for all the functionality allowing us to override the default methods as need it.
Due this logic is already handled by the image editor there's no need for us to mock this logic if not required.
If no editor or mime is supported there's no need to go down the logic of the function creating an image if no editor is available or if the mime is not supported.
felixarntz
approved these changes
Mar 24, 2022
felixarntz
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
@mitogh Awesome work catching and fixing this!
Sorry, something went wrong.
adamsilverstein
approved these changes
Mar 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #258
Relevant technical choices
The update uses WP internals to allow for a more appropriate editor instead of the default one based only on the image file when the provided mime type would make a difference as the provided mime type might be supported for other editors besides the default one.
Checklist