FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Introduce `webp_uploads_prefer_smaller_image_file` filter allowing to opt in to preferring the smaller image file by felixarntz · Pull Request #287 · WordPress/performance · GitHub

/ performance Public

Introduce webp_uploads_prefer_smaller_image_file filter allowing to opt in to preferring the smaller image file - #287

Merged
felixarntz merged 3 commits into
trunkfrom
enhancement/smaller-image-file-optin
Apr 14, 2022
ConversationCommits (3)ChecksFiles changed
Merged

Introduce webp_uploads_prefer_smaller_image_file filter allowing to opt in to preferring the smaller image file#287
felixarntz merged 3 commits into
trunkfrom
enhancement/smaller-image-file-optin

Conversation

felixarntz commented Apr 8, 2022

Copy link
Copy Markdown
Member

Summary

Fixes #286

Relevant technical choices

  • A simpler solution would have been to just remove the add_filter call to the new function, but that would make it much less intuitive for developers, and they would need to use this "generic" filter, and remember the name of our "internal" function.
  • A dedicated filter is much more intuitive and easy to use.
  • I chose webp_uploads_prefer_smaller_image_file for the filter name for now.

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

Introduce webp_uploads_prefer_smaller_image_file filter to opt in to …
539d04a 
…preferring the smaller image file regardless of MIME type.
felixarntz added [Type] Enhancement A suggestion for improvement of an existing feature [Focus] Images [Plugin] Modern Image Formats Issues for the Modern Image Formats plugin (formerly WebP Uploads) labels Apr 8, 2022
felixarntz added this to the 1.0.0 milestone Apr 8, 2022
felixarntz requested review from jjgrainger and mitogh April 8, 2022 17:43
felixarntz mentioned this pull request Apr 8, 2022
Closed
adamsilverstein reviewed Apr 13, 2022
View reviewed changes
Comment thread modules/images/webp-uploads/load.php Outdated
adamsilverstein requested changes Apr 13, 2022
View reviewed changes

adamsilverstein left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

left some small feedback points

adamsilverstein self-requested a review April 14, 2022 16:24
felixarntz merged commit faa8156 into trunk Apr 14, 2022
felixarntz deleted the enhancement/smaller-image-file-optin branch April 14, 2022 16:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

adamsilverstein adamsilverstein approved these changes
mitogh mitogh approved these changes
getsource Awaiting requested review from getsource
jjgrainger Awaiting requested review from jjgrainger

Assignees

No one assigned

Labels

[Plugin] Modern Image Formats Issues for the Modern Image Formats plugin (formerly WebP Uploads) [Type] Enhancement A suggestion for improvement of an existing feature

Projects

None yet

Milestone

1.0.0

Development

Successfully merging this pull request may close these issues.

Only use smaller file size based on opt-in since it is not part of the core feature scope

3 participants

Back | FazBrowse Home | New Git URL