FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Only update the specified target images when an image is edited. by mitogh · Pull Request #301 · WordPress/performance · GitHub

/ performance Public

Only update the specified target images when an image is edited. - #301

Merged
felixarntz merged 14 commits into
release/1.1.0from
feature/update-secondary-image-onedit-with-targets
May 12, 2022
ConversationCommits (14)ChecksFiles changed
Merged

Only update the specified target images when an image is edited.#301
felixarntz merged 14 commits into
release/1.1.0from
feature/update-secondary-image-onedit-with-targets

Conversation

mitogh commented Apr 16, 2022

Copy link
Copy Markdown
Member

Summary

Fixes #299

Relevant technical choices

Allow to select specific target images when editing an image, if either: thumbnail, all except thumbnail or all is selected the edit behavior should only use the specified images instead of applying the edit to all the images regardless of the selected target.

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

mitogh added 5 commits April 13, 2022 19:47
Add assertions for target type of edits
a3dee98 
When an edit with a target occurrs make sure that only the specified
images are modified, and the metadata reflects this changes based on
the specified target from the media section
Merge branch 'trunk' into feature/update-secondary-image-onedit-with-…
04d1676 
…targets
Merge branch 'trunk' into feature/update-secondary-image-onedit-with-…
a278dad 
…targets
Migrate tests to verify image edits to new file location
7a36d1d 
Move the tests from the single location into the correct
file where the image edits are located.
Handle the scenario when a target is selected.
5ecffc8 
When an image is selected for a target make sure that only
the selected target images are processed instead of processing
all the images when is not required or desired.

Fixes #299
mitogh added [Type] Bug An existing feature is broken [Focus] Images labels Apr 16, 2022
mitogh added this to the First release after 1.0.0 milestone Apr 16, 2022
mitogh self-assigned this Apr 16, 2022
mitogh changed the title Feature/update secondary image onedit with targets Only update the specified target images when an image is edited. Apr 16, 2022
eugene-manuilov requested changes Apr 21, 2022
View reviewed changes
Comment thread modules/images/webp-uploads/image-edit.php Outdated
mitogh requested a review from eugene-manuilov April 23, 2022 17:59
eugene-manuilov approved these changes Apr 25, 2022
View reviewed changes

eugene-manuilov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. Thanks, @mitogh.

felixarntz reviewed May 9, 2022
View reviewed changes

felixarntz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@mitogh Mostly lgtm, a few minor comments. One more critical thing, the rest is around doc comments.

Comment thread modules/images/webp-uploads/image-edit.php Outdated
Comment thread modules/images/webp-uploads/image-edit.php Outdated
Comment thread modules/images/webp-uploads/image-edit.php
Comment thread modules/images/webp-uploads/image-edit.php

felixarntz commented May 10, 2022

Copy link
Copy Markdown
Member

@mitogh @eugene-manuilov I've updated the base branch to release/1.1.0, with the goal to get this into the upcoming release. Would one of you be able to address the final feedback? There's also a merge conflict to address.

felixarntz changed the base branch from trunk to release/1.1.0 May 10, 2022 19:56

mitogh commented May 10, 2022

Copy link
Copy Markdown
Member Author

Thanks I can take a look at the feedback later today and resolve any remaining conflicts.

mxbclang commented May 11, 2022

Copy link
Copy Markdown
Contributor

👋 @mitogh We're in a bit of a rush with this one in prep for Monday's release, so @mehulkaklotar is going to finish this one up. Thank you for continuing to work on this to this point!

mxbclang assigned mehulkaklotar and unassigned mitogh May 11, 2022
mehulkaklotar and others added 3 commits May 12, 2022 13:35
Update modules/images/webp-uploads/image-edit.php
91427d2 
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
Update modules/images/webp-uploads/image-edit.php
fb8d988 
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
Update modules/images/webp-uploads/image-edit.php
d71045f 
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
mehulkaklotar requested a review from felixarntz May 12, 2022 11:55

mitogh commented May 12, 2022

Copy link
Copy Markdown
Member Author

Sure @bethanylang sorry I was not able to get it done in time.

Thanks, @mehulkaklotar for taking this one to the finish line.

jjgrainger approved these changes May 12, 2022
View reviewed changes

jjgrainger left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks @mehulkaklotar Latest changes look good to me

felixarntz approved these changes May 12, 2022
View reviewed changes

felixarntz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks @mitogh and @mehulkaklotar!

felixarntz merged commit d39c6aa into release/1.1.0 May 12, 2022
felixarntz deleted the feature/update-secondary-image-onedit-with-targets branch May 12, 2022 16:07
felixarntz mentioned this pull request May 12, 2022
Closed
swissspidy added [Plugin] Modern Image Formats Issues for the Modern Image Formats plugin (formerly WebP Uploads) and removed [Module] WebP Support labels Jul 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mehulkaklotar mehulkaklotar left review comments
eugene-manuilov eugene-manuilov approved these changes
jjgrainger jjgrainger approved these changes
felixarntz felixarntz approved these changes
adamsilverstein Awaiting requested review from adamsilverstein adamsilverstein is a code owner
getsource Awaiting requested review from getsource

Assignees

mehulkaklotar

Labels

[Plugin] Modern Image Formats Issues for the Modern Image Formats plugin (formerly WebP Uploads) [Type] Bug An existing feature is broken

Projects

None yet

Milestone

1.1.0

Development

Successfully merging this pull request may close these issues.

When an image is edited, perform updates only to the specified target

7 participants

Back | FazBrowse Home | New Git URL