| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
+1 looks good and support adding this. Since you hooked on head, this would be straightforward to exclude if users want that (remove the hook). |
Sorry, something went wrong.
|
We should be rather explicit in the changelog about this as it sounds like it automatically opts a site into this data gathering though I think some details from the related issue help spell out the rationale here (and hopefully anyone who's installed the plugin would be open to the generator tag if that helps prove that certain modules are worth bringing into core). |
Sorry, something went wrong.
There was a problem hiding this comment.
LGTM, very supportive of this (to the extent that I believe WP core should provide plugin information automatically without plugins needing to add their own tags 😄 ). Even more so for this plugin specifically since it will enable further measurement which is crucial to validate features which are aimed at being implemented in WordPress core.
Sorry, something went wrong.
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Definitely, this should be highlighted in the changelog (which it will be given that this PR is marked as a feature). Any data gathering based on this though would be similar to WordPress's own generator tag, which is there by default. But I agree that it needs to be obvious in the changelog. |
Sorry, something went wrong.
There was a problem hiding this comment.
LGTM 🌮
Sorry, something went wrong.
|
how to remove the unnecessary performance lab generator tag from the meta tags? i don't want to have it in the source code. i also removed the wordpress generator tag via functions.php so that you don't see the wordpress version in the source code. what exactly is the function for functions.php to remove the performance lab meta tag? I found the solution myself. Just put the following line in the functions.php: remove_action('wp_head', 'perflab_render_generator'); And you're rid of the unnecessary entry. |
Sorry, something went wrong.
|
@dajana91 Thank you for your feedback here and in your forum post. If we do decide to remove this tag, we will open a separate issue. |
Sorry, something went wrong.
|
@dajana91 If you prefer to remove the generator tag, you can do by adding the following code to your site: remove_action( 'wp_head', 'perflab_render_generator' );However, note that the generator tag exists to be able to have public performance metrics in HTTP Archive to assess and prove how certain modules of the Performance Lab plugin improve performance, which is important in order to get them eventually merged into WordPress core. By removing the tag, the site will no longer contribute to these. |
Sorry, something went wrong.
|
@felixarntz I don't care. I don't want unasked additional information in my source code that doesn't belong there. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Summary
Fixes #321
Relevant technical choices
Checklist