Improve autoloaded options check by highlighting largest autoloaded options by rytisder · Pull Request #353 · WordPress/performance · GitHub

Summary

Example:

Fixes #350

Relevant technical choices

Checklist

PR has either [Focus] or Infrastructure label.
PR has a [Type] label.
PR has a milestone or the no milestone label.

@rytisder Thank you for the pull request!

This looks great. I have a few bits of small feedback, most importantly it would be great to make the threshold value filterable so that external code such as plugins can change it.

@rytisder Thanks for fixing it so quickly.

@rytisder Thank for the updates, looks great! I just left a few more comments, almost all of them small details. Functionally this is already good, but it would be great if you could address the remaining feedback.

FYI no need to force-push, we typically just work with full commit history. So you can just add commits as you go.

Hello @rytisder thanks for the PR, it really makes this site health check more self-explanatory and complete :)
I left a small comment, and I would add maybe a unit test to covering perflab_aao_autoloaded_options()
As for the rest, looks good to me.
Also, don't forget to add you as code owner for this module.

@rytisder I will add some additional feedback on the PR, Below is the description for changes that I request.

You have used the static wp_options table name that needs to update.
Then </tr> missing on code https://github.com/rytisder/performance/blob/feature/implement-autoload-explanation-table/modules/site-health/audit-autoloaded-options/load.php#L155 once it will be added it automatically use WordPress grid design like the attached image.

Note: To get this site health report in this image I changed some threshold values.

@felixarntz In WordPress site health report it doesn't use a number column to identify its column number in any of their site health report in the info tab( WordPress, Directories and Sizes, Server, etc..) so for consistency do we need to remove it?

@mukeshpanchal27 Thank you, great additional points!

In WordPress site health report it doesn't use a number column to identify its column number in any of their site health report in the info tab( WordPress, Directories and Sizes, Server, etc..) so for consistency do we need to remove it?

Agreed, let's remove the first # column.

@rytisder Would be great if you could follow up on the additional feedback above! :)

@felixarntz, all suggestions mentioned above are pushed! 🙂

This isn't ready yet due to the outstanding iterations requested, so I'll remove the 1.3.0 milestone from here. Once this gets picked up and continued towards merge, we can add a milestone again.

@rytisder Will you be able to continue on the iterations requested above? If not, would you be open to another contributor taking over and continuing your work?

Reminder:

@rytisder Will you be able to continue on the iterations requested above? If not, would you be open to another contributor taking over and continuing your work?

@rytisder Thanks for the update. PR looks good now. Can you please address feedback and merge the latest changes from trunk into your branch.

Set milestone to 1.5. Feel free to update change it if this is not ready.

@mukeshpanchal27 Since the remaining 2 tweaks from https://github.com/WordPress/performance/pull/353/files#r967984960 and #353 (review) are so tiny, let's merge this and then addresse those things in a follow up PR right after, if you're okay with that.

Thank you very much, @rytisder! For the remaining work on this PR, we will create a separate PR.

@tillkruss Can you please review so we can merge this and add new follow-up PR to address remaining points.

Document is missing for the filter perflab_aao_autoloaded_options_table_threshold

@mukeshpanchal27

Can you please review so we can merge this and add new follow-up PR to address remaining points.

Document is missing for the filter perflab_aao_autoloaded_options_table_threshold

Looks like we can actually edit the branch here directly. In that case, we could also adjust it directly in here. But either way works, would be great if you could complete the work here. 🙌

Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com>

rytisder requested a review from manuelRod as a code owner June 2, 2022 15:11

felixarntz added [Type] Enhancement A suggestion for improvement of an existing feature [Focus] Site Health labels Jun 2, 2022

felixarntz added this to the 1.2.0 milestone Jun 2, 2022

felixarntz reviewed Jun 2, 2022

View reviewed changes

rytisder force-pushed the feature/implement-autoload-explanation-table branch from 93cdfff to 85ea43d Compare June 2, 2022 15:47

mukeshpanchal27 reviewed Jun 4, 2022

View reviewed changes

Comment thread modules/site-health/audit-autoloaded-options/load.php Outdated

Comment thread modules/site-health/audit-autoloaded-options/load.php Outdated

rytisder force-pushed the feature/implement-autoload-explanation-table branch from 85ea43d to f73bb65 Compare June 4, 2022 11:56

Implement autoload explanation table

9d2539d

rytisder force-pushed the feature/implement-autoload-explanation-table branch from f73bb65 to 9d2539d Compare June 4, 2022 11:58

felixarntz reviewed Jun 6, 2022

View reviewed changes

tillkruss requested changes Jun 7, 2022

View reviewed changes

Comment thread modules/site-health/audit-autoloaded-options/load.php Outdated

mukeshpanchal27 reviewed Jun 9, 2022

View reviewed changes

Comment thread modules/site-health/audit-autoloaded-options/load.php Outdated

Comment thread modules/site-health/audit-autoloaded-options/load.php Outdated

felixarntz modified the milestones: 1.2.0, 1.3.0 Jun 14, 2022

rytisder added 2 commits June 16, 2022 14:21

Fix PHPDoc, HTML table, add translations and remove #column

dfce948

Fix function call

b049a60

tillkruss requested changes Jun 16, 2022

View reviewed changes

Comment thread modules/site-health/audit-autoloaded-options/load.php Outdated

felixarntz mentioned this pull request Jun 30, 2022

Remove Experimental label from Autoloaded Options Site Health audit #409

Closed

mxbclang assigned rytisder Jul 1, 2022

felixarntz removed this from the 1.3.0 milestone Jul 14, 2022

Display size in MB

24d063b

mukeshpanchal27 reviewed Sep 12, 2022

View reviewed changes

Comment thread modules/site-health/audit-autoloaded-options/load.php Outdated

mukeshpanchal27 added this to the 1.5.0 milestone Sep 12, 2022

mukeshpanchal27 requested review from felixarntz and tillkruss September 12, 2022 05:32

mukeshpanchal27 reviewed Sep 12, 2022

View reviewed changes

Comment thread modules/site-health/audit-autoloaded-options/load.php Outdated

felixarntz approved these changes Sep 12, 2022

View reviewed changes

felixarntz changed the title Improve wp_options autoload audit Improve autoloaded options check by highlighting largest autoloaded options Sep 12, 2022

felixarntz added [Type] Enhancement A suggestion for improvement of an existing feature and removed [Type] Enhancement A suggestion for improvement of an existing feature labels Sep 12, 2022

felixarntz and others added 2 commits September 12, 2022 12:38

Merge branch 'trunk' into feature/implement-autoload-explanation-table

bbbbe52

Update the escaping

2d52a81

mukeshpanchal27 reviewed Sep 13, 2022

View reviewed changes

Comment thread modules/site-health/audit-autoloaded-options/load.php Outdated

Remove var_dump

3b05c2e

mukeshpanchal27 approved these changes Sep 13, 2022

View reviewed changes

tillkruss approved these changes Sep 13, 2022

View reviewed changes

mukeshpanchal27 reviewed Sep 14, 2022

View reviewed changes

Comment thread modules/site-health/audit-autoloaded-options/load.php

peterwilsoncc reviewed Sep 14, 2022

View reviewed changes

Comment thread modules/site-health/audit-autoloaded-options/load.php

Add missing document for the filter.

9f69812

Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com>

mukeshpanchal27 merged commit 43369da into WordPress:trunk Sep 14, 2022

Improve autoloaded options check by highlighting largest autoloaded options by rytisder · Pull Request #353 · WordPress/performance · GitHub

Uh oh!

Improve autoloaded options check by highlighting largest autoloaded options - #353

Conversation

rytisder commented Jun 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Relevant technical choices

Checklist

Uh oh!

felixarntz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mukeshpanchal27 commented Jun 4, 2022

Uh oh!

felixarntz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

manuelRod commented Jun 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

mukeshpanchal27 commented Jun 9, 2022

Uh oh!

Uh oh!

Uh oh!

felixarntz commented Jun 14, 2022

Uh oh!

rytisder commented Jun 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

felixarntz commented Jul 14, 2022

Uh oh!

mukeshpanchal27 commented Aug 1, 2022

Uh oh!

mukeshpanchal27 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mukeshpanchal27 commented Sep 12, 2022

Uh oh!

Uh oh!

felixarntz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mukeshpanchal27 left a comment

Choose a reason for hiding this comment

Uh oh!

mukeshpanchal27 commented Sep 13, 2022

Uh oh!

felixarntz commented Sep 13, 2022

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

rytisder commented Jun 2, 2022 •
edited
Loading

manuelRod commented Jun 7, 2022 •
edited
Loading

rytisder commented Jun 16, 2022 •
edited
Loading