Use wp_filesize instead of filesize if available - #376
Merged
felixarntz merged 7 commits intoJun 15, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
mehulkaklotar
requested review from
adamsilverstein,
felixarntz,
manuelRod and
mitogh
as code owners
June 15, 2022 10:18
akshitsethi
reviewed
Jun 15, 2022
Comment thread
load.php
Outdated
Comment thread
modules/site-health/audit-enqueued-assets/helper.php
Outdated
mitogh
reviewed
Jun 15, 2022
mitogh
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Small suggestion on the doc block since 6.0 was already released.
Looking good overall.
Sorry, something went wrong.
Comment thread
polyfills.php
Outdated
felixarntz
reviewed
Jun 15, 2022
felixarntz
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
@mehulkaklotar Thank you, that looks solid. Just one tiny documentation follow-up comment.
Sorry, something went wrong.
Co-authored-by: Crisoforo Gaspar Hernández <hello@crisoforo.com>
akshitsethi
approved these changes
Jun 15, 2022
akshitsethi
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM 💯
Sorry, something went wrong.
felixarntz
approved these changes
Jun 15, 2022
felixarntz
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Great work, thank you @mehulkaklotar!
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WordPress 6.0 introduced the wp_filesize() function which should be used in favor of PHP's filesize() going forward.
Fixes #344
Relevant technical choices
This PR changes filesize function to wp_filesize everywhere it was used in the plugin. Code and test cases.
Checklist