FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Ensure incorrect usage of `webp_uploads_upload_image_mime_transforms` filter is treated correctly by jjgrainger · Pull Request #393 · WordPress/performance · GitHub

/ performance Public

Ensure incorrect usage of webp_uploads_upload_image_mime_transforms filter is treated correctly - #393

Merged
felixarntz merged 3 commits into
trunkfrom
fix/361-webp-image-mime-transforms-filter
Jun 23, 2022
ConversationCommits (3)ChecksFiles changed
Merged

Ensure incorrect usage of webp_uploads_upload_image_mime_transforms filter is treated correctly#393
felixarntz merged 3 commits into
trunkfrom
fix/361-webp-image-mime-transforms-filter

Conversation

jjgrainger commented Jun 22, 2022 •
edited by felixarntz
Loading

Copy link
Copy Markdown
Contributor

Summary

Fixes #361

Relevant technical choices

  • Removes casting the value returned by the webp_uploads_upload_image_mime_transforms to an array.
  • Add tests to confirm behaviour works as expected based on webp_uploads_get_upload_image_mime_transforms comments.

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

jjgrainger added [Type] Bug An existing feature is broken [Focus] Images no milestone PRs that do not have a defined milestone for release labels Jun 22, 2022
jjgrainger added [Type] Enhancement A suggestion for improvement of an existing feature and removed [Type] Bug An existing feature is broken labels Jun 22, 2022
jjgrainger mentioned this pull request Jun 22, 2022
Closed
felixarntz approved these changes Jun 22, 2022
View reviewed changes

felixarntz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@jjgrainger Looks good, +1 for the extensive test coverage!

felixarntz added this to the 1.3.0 milestone Jun 22, 2022
felixarntz removed the no milestone PRs that do not have a defined milestone for release label Jun 22, 2022
felixarntz changed the title Fix webp_uploads_upload_image_mime_transforms filter Ensure incorrect usage of webp_uploads_upload_image_mime_transforms filter is treated correctly Jun 22, 2022
felixarntz added [Type] Bug An existing feature is broken [Plugin] Modern Image Formats Issues for the Modern Image Formats plugin (formerly WebP Uploads) and removed [Type] Enhancement A suggestion for improvement of an existing feature labels Jun 22, 2022
eugene-manuilov approved these changes Jun 23, 2022
View reviewed changes

eugene-manuilov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM 👍

felixarntz merged commit ee01a8d into trunk Jun 23, 2022
felixarntz deleted the fix/361-webp-image-mime-transforms-filter branch June 23, 2022 23:21
mukeshpanchal27 mentioned this pull request Jun 28, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

eugene-manuilov eugene-manuilov approved these changes
felixarntz felixarntz approved these changes
mitogh mitogh approved these changes
adamsilverstein Awaiting requested review from adamsilverstein
mukeshpanchal27 Awaiting requested review from mukeshpanchal27

Assignees

No one assigned

Labels

[Plugin] Modern Image Formats Issues for the Modern Image Formats plugin (formerly WebP Uploads) [Type] Bug An existing feature is broken

Projects

None yet

Milestone

1.3.0

Development

Successfully merging this pull request may close these issues.

Optimize: webp_uploads_upload_image_mime_transforms filter

4 participants

Back | FazBrowse Home | New Git URL