FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Do not show admin pointer in multisite Network Admin by mukeshpanchal27 · Pull Request #394 · WordPress/performance · GitHub

Do not show admin pointer in multisite Network Admin - #394

Merged
felixarntz merged 2 commits into
trunkfrom
fix/387-dont-show-admin-pointer-in-multisite
Jun 29, 2022
Merged

Do not show admin pointer in multisite Network Admin#394
felixarntz merged 2 commits into
trunkfrom
fix/387-dont-show-admin-pointer-in-multisite

Conversation

mukeshpanchal27 commented Jun 24, 2022
edited by akshitsethi
Loading

Copy link
Copy Markdown
Member

Summary

PR includes the solution that does not show an admin pointer in the multisite Network Admin.

Fixes #387

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

mukeshpanchal27 added [Type] Bug An existing feature is broken Infrastructure Issues for the overall performance plugin infrastructure no milestone PRs that do not have a defined milestone for release labels Jun 24, 2022

jjgrainger left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

eugene-manuilov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

akshitsethi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

💯

felixarntz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@mukeshpanchal27 Looks good, just one additional request.

Comment thread admin/load.php Outdated
felixarntz added this to the 1.3.0 milestone Jun 28, 2022
felixarntz removed the no milestone PRs that do not have a defined milestone for release label Jun 28, 2022

felixarntz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@mukeshpanchal27 Awesome, thanks!

felixarntz merged commit e314595 into trunk Jun 29, 2022
felixarntz deleted the fix/387-dont-show-admin-pointer-in-multisite branch June 29, 2022 16:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Infrastructure Issues for the overall performance plugin infrastructure [Type] Bug An existing feature is broken

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Do not show admin pointer in multisite Network Admin

5 participants


Back | FazBrowse Home | New Git URL