FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix PHP notice and bug in logic for when `webp_uploads_prefer_smaller_image_file` filter is set to `true` by mukeshpanchal27 · Pull Request #397 · WordPress/performance · GitHub

/ performance Public

Fix PHP notice and bug in logic for when webp_uploads_prefer_smaller_image_file filter is set to true - #397

Merged
felixarntz merged 1 commit into
trunkfrom
fix/396-undefine-error
Jun 28, 2022
ConversationCommits (1)ChecksFiles changed
Merged

Fix PHP notice and bug in logic for when webp_uploads_prefer_smaller_image_file filter is set to true#397
felixarntz merged 1 commit into
trunkfrom
fix/396-undefine-error

Conversation

mukeshpanchal27 commented Jun 28, 2022 •
edited by felixarntz
Loading

Copy link
Copy Markdown
Member

Summary

When I work on #372 bug I found this bug that needs to fix.

Fixes #396

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

mukeshpanchal27 added [Type] Bug An existing feature is broken [Focus] Images [Plugin] Modern Image Formats Issues for the Modern Image Formats plugin (formerly WebP Uploads) no milestone PRs that do not have a defined milestone for release labels Jun 28, 2022
felixarntz approved these changes Jun 28, 2022
View reviewed changes

felixarntz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Great catch!

felixarntz changed the title When webp_uploads_prefer_smaller_image_file is set to true, an undefine error occurs Fix PHP notice and bug in logic for when webp_uploads_prefer_smaller_image_file filter is set to true Jun 28, 2022
felixarntz added this to the 1.3.0 milestone Jun 28, 2022
felixarntz removed the no milestone PRs that do not have a defined milestone for release label Jun 28, 2022
felixarntz merged commit 5a7b891 into trunk Jun 28, 2022
felixarntz deleted the fix/396-undefine-error branch June 28, 2022 18:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

akshitsethi akshitsethi approved these changes
felixarntz felixarntz approved these changes
jjgrainger Awaiting requested review from jjgrainger
adamsilverstein Awaiting requested review from adamsilverstein
mitogh Awaiting requested review from mitogh

Assignees

No one assigned

Labels

[Plugin] Modern Image Formats Issues for the Modern Image Formats plugin (formerly WebP Uploads) [Type] Bug An existing feature is broken

Projects

None yet

Milestone

1.3.0

Development

Successfully merging this pull request may close these issues.

When webp_uploads_prefer_smaller_image_file is set to true, an undefine error occurs

4 participants

Back | FazBrowse Home | New Git URL