Fix an infinite loop in the WebP fallback mechanism - #433
Merged
felixarntz merged 2 commits intoJul 15, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
mukeshpanchal27
requested review from
eugene-manuilov,
jjgrainger and
mehulkaklotar
July 15, 2022 10:44
mukeshpanchal27
requested review from
adamsilverstein,
felixarntz and
mitogh
as code owners
July 15, 2022 10:44
eugene-manuilov
requested changes
Jul 15, 2022
Comment thread
modules/images/webp-uploads/load.php
Outdated
3 tasks
jjgrainger
approved these changes
Jul 15, 2022
jjgrainger
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Good spot on the issue and fix
Sorry, something went wrong.
eugene-manuilov
approved these changes
Jul 15, 2022
eugene-manuilov
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
mehulkaklotar
approved these changes
Jul 15, 2022
mehulkaklotar
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM 🚀
Sorry, something went wrong.
mitogh
approved these changes
Jul 15, 2022
felixarntz
approved these changes
Jul 15, 2022
felixarntz
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Great catch @mukeshpanchal27, and thank you for the quick fix!
This will need to go into the 1.3.0 release of course since it is critical, so I'll change the base branch accordingly.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #432
Relevant technical choices
Checklist