Fix REST API support for plain permalinks. - #457
Merged
felixarntz merged 1 commit intoAug 8, 2022
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
peterwilsoncc
requested review from
adamsilverstein,
felixarntz and
mitogh
as code owners
July 28, 2022 03:36
jjgrainger
approved these changes
Jul 28, 2022
jjgrainger
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Thanks @peterwilsoncc looks good
Sorry, something went wrong.
adamsilverstein
approved these changes
Jul 28, 2022
adamsilverstein
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Nice!
Sorry, something went wrong.
mukeshpanchal27
approved these changes
Jul 29, 2022
mukeshpanchal27
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
🚀
Sorry, something went wrong.
felixarntz
approved these changes
Aug 8, 2022
felixarntz
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
@peterwilsoncc Great catch, thanks!
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ensure the WebP fallback JavaScript works with sites using plain permalinks.
Fixes #456.
Relevant technical choices
I decided to copy the approach used in the @wordpress/apiFetch rootUrl middleware that handles this exact issue. It seems to work.
Ensures that the querystring does not have a double ? if the site is configured using plain permalinks.
Checklist