Fix incorrect usage of badge colors in all Site Health checks - #472
Conversation
Sorry, something went wrong.
mehulkaklotar
left a comment
There was a problem hiding this comment.
Looks good! 🚀
Sorry, something went wrong.
ankitrox
left a comment
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
| $base_description = __( 'Autoloaded options are configuration settings for plugins and themes that are automatically loaded with every page load in WordPress. Having too many autoloaded options can slow down your site.', 'performance-lab' ); | ||
|
|
||
| $result = array( | ||
| 'label' => esc_html__( 'Autoloaded options are acceptable', 'performance-lab' ), |
There was a problem hiding this comment.
I noticed we are applying esc_html__ inconsistently to translations and that you removed a bunch in this PR.
For core, we don't escape translations, however for plugins I generally recommend escaping (as 10up recommends).
Maybe rather than changing here we can open a follow issue to use a uniform approach and change throughout the plugin?
Sorry, something went wrong.
There was a problem hiding this comment.
While escaping is recommended for plugins more than core, the rules also say that escaping should happen at the output level. In all the places here though, we're only writing data into an array, so per those guidelines escaping here would not follow the best practice.
All escaping for Site Health check content should happen in WordPress core per that definition, since that's where the data is being output.
Sorry, something went wrong.
Summary
Fixes #471
Relevant technical choices
Checklist