FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add module to alert about excessive JS and CSS assets by manuelRod · Pull Request #54 · WordPress/performance · GitHub

/ performance Public

Add module to alert about excessive JS and CSS assets #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
felixarntz merged 21 commits into from
Jan 28, 2022
Conversation 95 Commits 21 Checks 0 Files changed
Merged

Add module to alert about excessive JS and CSS assets #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
a7883dc
Plugin https://github.com/audrasjb/site-health-audit-enqueued-assets/…
manuelRod Dec 8, 2021
83fd785
partial unit testing added.
manuelRod Dec 9, 2021
69d1208
Adding more unit testing.
manuelRod Dec 9, 2021
bda604d
adding missing tests.
manuelRod Dec 10, 2021
663fe3a
removing duplicated get_transient
manuelRod Dec 15, 2021
3a5cc54
Adding filter for transient, and invalidate cache on switch_theme, ac…
manuelRod Dec 15, 2021
2e555a1
Adding user action to null transient cache.
manuelRod Dec 15, 2021
c668003
redirects after cleaning cache to site-health.php without query args
manuelRod Dec 16, 2021
2baf8fe
All prefix needs to be updated to perflab_
manuelRod Dec 16, 2021
327bed3
adding functionality to get resources sizes
manuelRod Dec 16, 2021
f7c2a60
Adding filesize to the transient cache, and functionality related to it.
manuelRod Dec 17, 2021
5333d7d
Merge branch 'trunk' into add/sitehealth-enqueued-assets
manuelRod Jan 10, 2022
b0ccda4
migrating module to new module structure
manuelRod Jan 10, 2022
2757e8c
migration to new module structure
manuelRod Jan 10, 2022
07a6a70
split code refactor, creation of a new helper file with helper method…
manuelRod Jan 10, 2022
47f4f9f
prefix fix
manuelRod Jan 10, 2022
84af518
refactor adding suggestions:
manuelRod Jan 10, 2022
a528fb4
changing wording and adding information about bellow threshold limits.
manuelRod Jan 11, 2022
e42b9c2
implementing new threshold limits
manuelRod Jan 11, 2022
90c17f8
Adding filters for limits. Fixing _n translatable strings.
manuelRod Jan 26, 2022
35edbca
nit-pick fixes
manuelRod Jan 27, 2022
File filter

Filter by extension

Filter by extension .php  (6) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
102 changes: 102 additions & 0 deletions modules/site-health/audit-enqueued-assets/helper.php
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -0,0 +1,102 @@
<?php
/**
* Helper functions used by module.
*
* @package performance-lab
* @since 1.0.0
*/

/**
* Gets total of enqueued scripts.
*
* @since 1.0.0
*
* @return int|false Number of total scripts or false if transient hasn't been set.
*/
function perflab_aea_get_total_enqueued_scripts() {
$enqueued_scripts = false;
$list_enqueued_scripts = get_transient( 'aea_enqueued_front_page_scripts' );
if ( $list_enqueued_scripts ) {
$enqueued_scripts = count( $list_enqueued_scripts );
}
return $enqueued_scripts;
}

/**
* Gets total size in bytes of Enqueued Scripts.
*
* @since 1.0.0
*
* @return int|false Byte Total size or false if transient hasn't been set.
*/
function perflab_aea_get_total_size_bytes_enqueued_scripts() {
$total_size = false;
$list_enqueued_scripts = get_transient( 'aea_enqueued_front_page_scripts' );
if ( $list_enqueued_scripts ) {
$total_size = 0;
foreach ( $list_enqueued_scripts as $enqueued_script ) {
$total_size += $enqueued_script['size'];
}
}
return $total_size;
}

/**
* Gets total of enqueued styles.
*
* @since 1.0.0
*
* @return int|false Number of total styles or false if transient hasn't been set.
*/
function perflab_aea_get_total_enqueued_styles() {
$enqueued_styles = false;
$list_enqueued_styles = get_transient( 'aea_enqueued_front_page_styles' );
if ( $list_enqueued_styles ) {
$enqueued_styles = count( $list_enqueued_styles );
}
return $enqueued_styles;
}

/**
* Gets total size in bytes of Enqueued Styles.
*
* @since 1.0.0
*
* @return int|false Byte Total size or false if transient hasn't been set.
*/
function perflab_aea_get_total_size_bytes_enqueued_styles() {
$total_size = false;
$list_enqueued_styles = get_transient( 'aea_enqueued_front_page_styles' );
if ( $list_enqueued_styles ) {
$total_size = 0;
foreach ( $list_enqueued_styles as $enqueued_style ) {
$total_size += $enqueued_style['size'];
}
}
return $total_size;
}

/**
* Convert full URL paths to absolute paths.
*
* @since 1.0.0
*
* @param string $resource_url URl resource link.
* @return string Returns absolute path to the resource.
*/
function perflab_aea_get_path_from_resource_url( $resource_url ) {
return ABSPATH . wp_make_link_relative( $resource_url );

felixarntz Jan 25, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This is okay for a start, but it's a bit oversimplified:

  • It is possible for URLs to be in a location that is not within ABSPATH, for example several sites have their wp-content directory separate, which is supported by WordPress.
  • WordPress may be in a subdirectory of the domain.

For most sites what you have here will work, but we should make sure to also accomodate those other sites.

I suggest we expand this as follows to at least cover for these two cases a bit better:

Suggested change
return ABSPATH . wp_make_link_relative( $resource_url );
if ( 0 === strpos( $resource_url, WP_CONTENT_URL ) ) {
return WP_CONTENT_DIR . substr( $resource_url, strlen( WP_CONTENT_URL ) );
}
$site_url = untrailingslashit( site_url() );
if ( 0 === strpos( $resource_url, $site_url ) ) {
return ABSPATH . substr( $resource_url, strlen( $site_url ) );
}
return ABSPATH . wp_make_link_relative( $resource_url );

manuelRod Jan 26, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@felixarntz can you give me an example of the first case? I cannot see it clearly.

Regarding WordPress may be in a subdirectory of the domain.
Do you mean something like this?
https://example.com/blog/wp-content/themes/test-theme/style.css ?
If that's the case, doesn't ABSPATH . wp_make_link_relative( $resource_url ) covers it too?

felixarntz Jan 26, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@manuelRod Some popular environments like https://github.com/roots/bedrock have their wp-content directory outside of the (rest of the) WordPress directory, so that URLs would be e.g. https://example.com/content/themes/... and https://example.com/wp/wp-includes/.... Both conditions I'm suggesting here cover that use-case, the first is for assets that come from the wp-content directory in a custom location, the second one for when the WordPress directory is in a subdirectory.

If that's the case, doesn't ABSPATH . wp_make_link_relative( $resource_url ) covers it too?

I don't think it does, since wp_make_link_relative simply removes the protocol and domain. Looking at my example above, that means you get /wp/wp-includes/..., and when you append that to ABSPATH, the wp directory would basically be in there twice. That's why for these cases we have to use the site_url() function, which is the "URL equivalent" of ABSPATH (the same way that WP_CONTENT_URL is the "URL equivalent" to WP_CONTENT_DIR).
}

/**
* If file exists, returns its size.
*
* @since 1.0.0
*
* @param string $file_src Path to the file.
* @return int Returns size if file exists, 0 if it doesn't.
*/
function perflab_aea_get_resource_file_size( $file_src ) {
return file_exists( $file_src ) ? filesize( $file_src ) : 0;
}

Loading
Back | FazBrowse Home | New Git URL