Fix opt-in checkbox for generating WebP and JPEG to also show on Multisite - #565
Merged
mehulkaklotar merged 5 commits intoOct 27, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
mehulkaklotar
marked this pull request as ready for review
October 20, 2022 12:40
mehulkaklotar
requested review from
adamsilverstein,
felixarntz and
mitogh
as code owners
October 20, 2022 12:40
Comment thread
modules/images/webp-uploads/settings.php
Outdated
felixarntz
requested changes
Oct 20, 2022
felixarntz
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
@mehulkaklotar Left a few points of feedback, this can be simplied quite a bit.
Sorry, something went wrong.
Comment thread
modules/images/webp-uploads/settings.php
Outdated
Comment thread
modules/images/webp-uploads/settings.php
Outdated
Comment thread
modules/images/webp-uploads/settings.php
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
felixarntz
approved these changes
Oct 26, 2022
felixarntz
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks @mehulkaklotar, looks great!
Sorry, something went wrong.
ankitrox
approved these changes
Oct 27, 2022
ankitrox
left a comment
Copy link
Copy Markdown
There was a problem hiding this comment.
💯
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #560
Relevant technical choices
PR adds checkbox setting for WebP and JPEG in Settings > Media in the default section in the multisite for each site.
Checklist