Fix SQLite notices related to undefined properties - #600
Merged
mukeshpanchal27 merged 3 commits intoDec 15, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
aristath
commented
Dec 14, 2022
| */ | ||
| function _real_escape( $str ) { | ||
| return SQLite3::escapeString( $str ); | ||
| return addslashes( $str ); |
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
This is the line that fixes #599
Sorry, something went wrong.
aristath
commented
Dec 14, 2022
Comment on lines
+1338
to
+1356
| if ( ! is_object( $row ) ) { | ||
| continue; | ||
| } | ||
| if ( property_exists( $row, 'name' ) ) { | ||
| $_columns['Field'] = $row->name; | ||
| } | ||
| if ( property_exists( $row, 'type' ) ) { | ||
| $_columns['Type'] = $row->type; | ||
| } | ||
| if ( property_exists( $row, 'notnull' ) ) { | ||
| $_columns['Null'] = $row->notnull ? 'NO' : 'YES'; | ||
| } | ||
| if ( property_exists( $row, 'pk' ) ) { | ||
| $_columns['Key'] = $row->pk ? 'PRI' : ''; | ||
| } | ||
| if ( property_exists( $row, 'dflt_value' ) ) { | ||
| $_columns['Default'] = $row->dflt_value; | ||
| } | ||
| $_results[] = new Perflab_SQLite_Object_Array( $_columns ); |
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
This is some additional defensive coding to ensure there are no errors.
Sorry, something went wrong.
felixarntz
approved these changes
Dec 14, 2022
felixarntz
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
@aristath Great work!
Sorry, something went wrong.
mukeshpanchal27
approved these changes
Dec 15, 2022
mukeshpanchal27
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks @aristath Now everything is good with import.
Sorry, something went wrong.
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #599
In addition to the above fix, I encountered some other notices when testing various plugins:
This PR adds some additional checks to ensure that $row is an object, and the properties exist before using them.