FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Enhance object-cache.php drop-in interoperability with other plugins by felixarntz · Pull Request #616 · WordPress/performance · GitHub

/ performance Public

Enhance object-cache.php drop-in interoperability with other plugins - #616

Merged
felixarntz merged 2 commits into
trunkfrom
fix/612-enhance-drop-in-interop
Jan 9, 2023
ConversationCommits (2)ChecksFiles changed
Merged

Enhance object-cache.php drop-in interoperability with other plugins#616
felixarntz merged 2 commits into
trunkfrom
fix/612-enhance-drop-in-interop

Conversation

felixarntz commented Dec 23, 2022

Copy link
Copy Markdown
Member

Summary

Fixes #612

Relevant technical choices

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

felixarntz added [Type] Bug An existing feature is broken Infrastructure Issues for the overall performance plugin infrastructure labels Dec 23, 2022
felixarntz added this to the 1.9.0 milestone Dec 23, 2022
tillkruss reviewed Dec 23, 2022
View reviewed changes
Comment thread load.php Outdated
// https://github.com/WordPress/performance/issues/612).
// In that case we can simply delete the main file since it is
// already backed up.
if ( $wp_filesystem->exists( WP_CONTENT_DIR . '/object-cache-plst-orig.php' ) ) {

tillkruss Dec 23, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

What's the plst reference?

felixarntz Dec 24, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Just a shorthand for "Performance Lab Server Timing" to make the file name more "unique" (e.g. in case another plugin would already do something similar using -orig suffix).

mukeshpanchal27 reviewed Jan 4, 2023
View reviewed changes

mukeshpanchal27 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks @felixarntz Overall looks solid to me. Left some feedbacks.

Comment thread load.php Outdated
Comment thread tests/load-tests.php
jjgrainger approved these changes Jan 5, 2023
View reviewed changes

jjgrainger left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks @felixarntz changes look good

mukeshpanchal27 approved these changes Jan 6, 2023
View reviewed changes

mukeshpanchal27 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks @felixarntz, LGTM!

felixarntz merged commit 245c9eb into trunk Jan 9, 2023
felixarntz deleted the fix/612-enhance-drop-in-interop branch January 9, 2023 19:28
jamesozzie mentioned this pull request Jan 25, 2023
Closed
jjgrainger mentioned this pull request Feb 9, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

tillkruss tillkruss left review comments
jjgrainger jjgrainger approved these changes
mukeshpanchal27 mukeshpanchal27 approved these changes
merkys7 merkys7 approved these changes
adamsilverstein Awaiting requested review from adamsilverstein

Assignees

No one assigned

Labels

Infrastructure Issues for the overall performance plugin infrastructure [Type] Bug An existing feature is broken

Projects

None yet

Milestone

1.9.0

Development

Successfully merging this pull request may close these issues.

object-cache.php conflicts with third party plugins

6 participants

Back | FazBrowse Home | New Git URL