FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix invalid docs and return types as highlighted by static analysis by kt-12 · Pull Request #645 · WordPress/performance · GitHub

/ performance Public

Fix invalid docs and return types as highlighted by static analysis - #645

Merged
mukeshpanchal27 merged 6 commits into
trunkfrom
bug/static-test-fixes
Feb 7, 2023
ConversationCommits (6)ChecksFiles changed
Merged

Fix invalid docs and return types as highlighted by static analysis#645
mukeshpanchal27 merged 6 commits into
trunkfrom
bug/static-test-fixes

Conversation

kt-12 commented Feb 6, 2023 •
edited by felixarntz
Loading

Copy link
Copy Markdown
Member

Summary

Fixes #622

Fix issues with doc type and return that was throwing error in static test.

Relevant technical choices

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

kt-12 added [Type] Bug An existing feature is broken Miscellaneous Issues not related to an existing focus area Infrastructure Issues for the overall performance plugin infrastructure no milestone PRs that do not have a defined milestone for release labels Feb 6, 2023
kt-12 changed the title Static test bug fixes Static test - fix doc types and return Feb 6, 2023
felixarntz added this to the 2.0.0 milestone Feb 6, 2023
felixarntz added [Focus] Database and removed no milestone PRs that do not have a defined milestone for release Miscellaneous Issues not related to an existing focus area labels Feb 6, 2023
felixarntz approved these changes Feb 6, 2023
View reviewed changes

felixarntz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@kt-12 Thanks, LGTM!

felixarntz changed the title Static test - fix doc types and return Fix invalid docs and return types as highlighted by static analysis Feb 6, 2023

felixarntz commented Feb 6, 2023

Copy link
Copy Markdown
Member

@aristath This fixes a few minor things in the SQLite module, so I wanted to make sure you see this. Right now we're in a bit of an unfortunate situation of having the code duplicated, so can you make sure to address this in your plugin as well? Should be a quick fix. (The return types need to align with the parent classes, for example.)

felixarntz commented Feb 6, 2023

Copy link
Copy Markdown
Member

@mukeshpanchal27 Can you give this a 2nd review and approval please?

mukeshpanchal27 approved these changes Feb 7, 2023
View reviewed changes

mukeshpanchal27 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks @kt-12, The changes look good to me!

mukeshpanchal27 merged commit b26dca8 into trunk Feb 7, 2023
mukeshpanchal27 deleted the bug/static-test-fixes branch February 7, 2023 04:00
aristath added a commit to WordPress/sqlite-database-integration that referenced this pull request Feb 7, 2023
backport WordPress/performance#645
11bec7e

aristath commented Feb 7, 2023

Copy link
Copy Markdown
Member

Backported to the standalone plugin as well 👍

westonruter mentioned this pull request May 15, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

felixarntz felixarntz approved these changes
mukeshpanchal27 mukeshpanchal27 approved these changes
OllieJones Awaiting requested review from OllieJones
JustinyAhin Awaiting requested review from JustinyAhin
aristath Awaiting requested review from aristath

Assignees

No one assigned

Labels

Infrastructure Issues for the overall performance plugin infrastructure [Type] Bug An existing feature is broken

Projects

None yet

Milestone

2.0.0

Development

Successfully merging this pull request may close these issues.

Benefit from static analysis

4 participants

Back | FazBrowse Home | New Git URL