FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix incorrect usage of `plugin_action_links_*` filter by kt-12 · Pull Request #647 · WordPress/performance · GitHub

/ performance Public

Fix incorrect usage of plugin_action_links_* filter - #647

Merged
mukeshpanchal27 merged 1 commit into
trunkfrom
bug/plugin_action_links_fix
Feb 6, 2023
ConversationCommits (1)ChecksFiles changed
Merged

Fix incorrect usage of plugin_action_links_* filter#647
mukeshpanchal27 merged 1 commit into
trunkfrom
bug/plugin_action_links_fix

Conversation

kt-12 commented Feb 6, 2023 •
edited by felixarntz
Loading

Copy link
Copy Markdown
Member

Summary

Fixes #646

Changed
add_action to add_filter

Relevant technical choices

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

kt-12 added [Type] Bug An existing feature is broken Infrastructure Issues for the overall performance plugin infrastructure no milestone PRs that do not have a defined milestone for release labels Feb 6, 2023
mukeshpanchal27 approved these changes Feb 6, 2023
View reviewed changes

mukeshpanchal27 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks @kt-12, Great catch. The changes LGTM!

mukeshpanchal27 added this to the 2.0.0 milestone Feb 6, 2023
mukeshpanchal27 removed the no milestone PRs that do not have a defined milestone for release label Feb 6, 2023
mukeshpanchal27 merged commit 2ebe0b7 into trunk Feb 6, 2023
mukeshpanchal27 deleted the bug/plugin_action_links_fix branch February 6, 2023 10:16
felixarntz changed the title Fixes plugin_action_links_ filter Fix incorrect usage of plugin_action_links_* filter Feb 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jjgrainger jjgrainger approved these changes
mukeshpanchal27 mukeshpanchal27 approved these changes
JustinyAhin Awaiting requested review from JustinyAhin
felixarntz Awaiting requested review from felixarntz

Assignees

No one assigned

Labels

Infrastructure Issues for the overall performance plugin infrastructure [Type] Bug An existing feature is broken

Projects

None yet

Milestone

2.0.0

Development

Successfully merging this pull request may close these issues.

Improper usage of add_action to update plugin action links

3 participants

Back | FazBrowse Home | New Git URL