FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Check for existing `$metadata['sizes']` to fix PHP warning by mukeshpanchal27 · Pull Request #648 · WordPress/performance · GitHub

/ performance Public

Check for existing $metadata['sizes'] to fix PHP warning - #648

Merged
mukeshpanchal27 merged 1 commit into
trunkfrom
fix/632-php-warnings
Feb 13, 2023
ConversationCommits (1)ChecksFiles changed
Merged

Check for existing $metadata['sizes'] to fix PHP warning#648
mukeshpanchal27 merged 1 commit into
trunkfrom
fix/632-php-warnings

Conversation

mukeshpanchal27 commented Feb 10, 2023 •
edited by felixarntz
Loading

Copy link
Copy Markdown
Member

Summary

Fixes #632

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

mukeshpanchal27 added [Type] Bug An existing feature is broken [Focus] Images [Plugin] Modern Image Formats Issues for the Modern Image Formats plugin (formerly WebP Uploads) labels Feb 10, 2023
mukeshpanchal27 added this to the 2.0.0 milestone Feb 10, 2023
mukeshpanchal27 marked this pull request as ready for review February 10, 2023 05:58
felixarntz approved these changes Feb 11, 2023
View reviewed changes

felixarntz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks @mukeshpanchal27!

felixarntz changed the title Check for existing $metadata['sizes'] to fix PHP warnings Check for existing $metadata['sizes'] to fix PHP warning Feb 11, 2023
kt-12 approved these changes Feb 13, 2023
View reviewed changes

kt-12 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks @mukeshpanchal27, LGTM!

mukeshpanchal27 merged commit 3e48f93 into trunk Feb 13, 2023
mukeshpanchal27 deleted the fix/632-php-warnings branch February 13, 2023 13:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

felixarntz felixarntz approved these changes
kt-12 kt-12 approved these changes
joemcgill Awaiting requested review from joemcgill
adamsilverstein Awaiting requested review from adamsilverstein
mitogh Awaiting requested review from mitogh

Assignees

No one assigned

Labels

[Plugin] Modern Image Formats Issues for the Modern Image Formats plugin (formerly WebP Uploads) [Type] Bug An existing feature is broken

Projects

None yet

Milestone

2.0.0

Development

Successfully merging this pull request may close these issues.

Check for existing $metadata['sizes'] to reduce PHP warnings

3 participants

Back | FazBrowse Home | New Git URL