Add file header to object-cache drop-in to clarify purpose - #649
Merged
felixarntz merged 2 commits intoFeb 14, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
mukeshpanchal27
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks @felixarntz, The changes look solid to me. Left few suggestions.
Sorry, something went wrong.
Comment thread
server-timing/object-cache.copy.php
Comment thread
server-timing/object-cache.copy.php
mukeshpanchal27
approved these changes
Feb 14, 2023
mukeshpanchal27
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks @felixarntz, LGTM!
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
@OllieJones @joemcgill Can one of you please give this a 2nd pass and approval when you have a second? |
Sorry, something went wrong.
OllieJones
approved these changes
Feb 14, 2023
OllieJones
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Looks exactly right to me. Thanks!
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #615
Checklist