FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add `wp-total` metric to default Server-Timing metrics by felixarntz · Pull Request #669 · WordPress/performance · GitHub

/ performance Public

Add wp-total metric to default Server-Timing metrics - #669

Merged
felixarntz merged 1 commit into
trunkfrom
add/server-timing-total-metric
Mar 14, 2023
ConversationCommits (1)ChecksFiles changed
Merged

Add wp-total metric to default Server-Timing metrics#669
felixarntz merged 1 commit into
trunkfrom
add/server-timing-total-metric

Conversation

felixarntz commented Mar 10, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Summary

Fixes #668

  • Note that in order to see the metric, you need to enable output buffering via the Server Timing API filter. See this Gist.
  • This data (also see WordPress Trac ticket) is an example where the code from this PR was already used.

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

felixarntz added [Type] Enhancement A suggestion for improvement of an existing feature Infrastructure Issues for the overall performance plugin infrastructure labels Mar 10, 2023
felixarntz added this to the 2.1.0 milestone Mar 10, 2023

felixarntz commented Mar 10, 2023

Copy link
Copy Markdown
Member Author

cc @oandregal

mukeshpanchal27 approved these changes Mar 13, 2023
View reviewed changes

mukeshpanchal27 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks @felixarntz, LGTM!

joemcgill reviewed Mar 13, 2023
View reviewed changes
Comment thread server-timing/defaults.php
felixarntz merged commit a92b560 into trunk Mar 14, 2023
felixarntz deleted the add/server-timing-total-metric branch March 14, 2023 22:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

joemcgill joemcgill approved these changes
mukeshpanchal27 mukeshpanchal27 approved these changes

Assignees

No one assigned

Labels

Infrastructure Issues for the overall performance plugin infrastructure [Type] Enhancement A suggestion for improvement of an existing feature

Projects

None yet

Milestone

2.1.0

Development

Successfully merging this pull request may close these issues.

Add Server-Timing metric for total load time

3 participants

Back | FazBrowse Home | New Git URL