Implement infrastructure for launching standalone plugins from modules, including WebP Uploads - #699
Merged
felixarntz merged 125 commits intoApr 5, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
…ded in later commits.
… order to export-ignore them
…-plugins CLI command for a build process to transform modules into standalone plugins
…Press/performance into feature/creating-standalone-plugins
…-module-specific-readme-files
…uild prior to unit testing of each.
Refresh feature branch with `trunk`
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
Generator meta tag for WebP Uploads standalone plugin
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
GitHub workflow to build and deploy standalone plugins
felixarntz
requested review from
JustinyAhin,
adamsilverstein and
mitogh
as code owners
April 5, 2023 16:39
34 tasks
mukeshpanchal27
approved these changes
Apr 5, 2023
joemcgill
approved these changes
Apr 5, 2023
joemcgill
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
It looks like everything that we need to create the standalone plugin for WebP Uploads is here. We will want to do a dry run of the manual workflow prior to running a real release. Given that we can only do that once this is committed to trunk, let's merge this, and create a follow-up issue to handle the final steps that need to be fixed before we run an actual release.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Thanks @joemcgill, I've opened #700 for this purpose. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This brings almost all Milestone 1 changes from #656 into the trunk branch, at first to publish only the WebP Uploads standalone plugin, as a first test. Once that is published, we will quickly follow up with the remaining standalone plugins (see #640).
This PR doesn't need an actual code review, just 2 approvals as a formality. All code in this branch has already been reviewed and approved in previous PRs.
Checklist