| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
…ation work correctly.
There was a problem hiding this comment.
LGTM 👍
Sorry, something went wrong.
There was a problem hiding this comment.
Thanks @felixarntz, Great work!
Sorry, something went wrong.
| 'images/dominant-color-images' => 'DOMINANT_COLOR_IMAGES_VERSION', | ||
| 'images/fetchpriority' => 'FETCHPRIORITY_VERSION', | ||
| 'images/webp-uploads' => 'WEBP_UPLOADS_VERSION', | ||
| 'database/sqlite' => 'SQLITE_MAIN_FILE', |
There was a problem hiding this comment.
@felixarntz @mukeshpanchal27 I added this so that the PL SQLite module option can not be accidentally enabled by the end user once the standalone plugin is activated, thus preventing the following unnecessary fatal error:
Fatal error: Cannot redeclare w_install (previously declared in /var/www/html/w-content/plugins/sqlite-database-integration/wp-includes/sqlite/install-functions.php:138)in /var/www/html/wp-content/plugins/performance/modules/database/sqlite/wp-includes/sqlite/install-functions.php on line 122
Sorry, something went wrong.
There was a problem hiding this comment.
Great catch!
Sorry, something went wrong.
There was a problem hiding this comment.
I've added a fix to prevent activation of the sqlite module when the standalone plugin is enabled. Tested the rest and looks good to go for me.
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Summary
Follow up to #739: When testing the migration flow from the SQLite module to the standalone plugin, @10upsimon noticed that the module is still active technically in case that the SQLite plugin gets deactivated after the migration. That is because the logic to deactivate the module was only applying on the SQLite database, but not the MySQL/MariaDB database.
This PR fixes that problem.
Relevant technical choices
Testing steps
The 7th point is the one that this PR fixes. Previously, the PL module would have been active at that point.
Checklist