Remove SQLite module - #764
Merged
mukeshpanchal27 merged 5 commits intoJul 6, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
added 4 commits
June 21, 2023 17:59
…le removal (as last resort following the migration routine in 2.4.0).
mukeshpanchal27
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks @felixarntz for the PR! It looks solid.
Can we also consider removing certain functions and text associated with SQLite?
- Activate and deactivated module code that introduce through module integration that we did not use for any other module.
- perflab_run_module_activation_deactivation()
- perflab_activate_module()
- perflab_deactivate_module()
- 'update_option_' . PERFLAB_MODULES_SETTING action
- 'add_option_' . PERFLAB_MODULES_SETTING action
- Remove SQLite Integration from readme.txt
Sorry, something went wrong.
aristath
approved these changes
Jun 22, 2023
Copy link
Copy Markdown
Member
Author
|
@mukeshpanchal27 While the functions you reference were added as part of the SQLite PR, they are generally applicable and part of the infrastructure itself, as they could be useful for any module in the future. So I think we should keep them. Regarding the readme.txt update, this will be taken care of automatically as part of the release process, via npm run readme. |
Sorry, something went wrong.
mukeshpanchal27
approved these changes
Jul 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #738
Checklist