| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
There was a problem hiding this comment.
Thank you @mukeshpanchal27 for the PR. I think there are a few things that can be simplified here. Most importantly, let's remove the additional piece of functionality in the module cards which wasn't required and makes the PR more complicated. I left more specific feedback below. Please let me know if you have any questions for clarification.
Sorry, something went wrong.
|
Thank you, @felixarntz and @westonruter, for the review feedback. I've simplified the logic, addressed all the feedback, and responded to some open questions. The PR is now ready for review. |
Sorry, something went wrong.
There was a problem hiding this comment.
@mukeshpanchal27 I left some follow up feedback, mostly minor things to clarify wording. For example, I think we should include in the user-facing message that the modules will be removed in the future, for a sense of urgency.
There's one larger consideration here that we may want to change, which I'm just realizing now:
Let me know what you think about this, or if you have any follow up questions. For now, it's probably best if you just address the more specific feedback below, and we can discuss the above separately afterwards (e.g. in Slack or in PR comments).
Sorry, something went wrong.
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
There was a problem hiding this comment.
@mukeshpanchal27 I just tested this again, and I think it looks almost ready to merge.
Regarding my feedback in #899 (review), I just now realized that you have a window.location.reload() in the JS, so that works perfectly fine then, and the AJAX with loading spinner still makes for a bit nicer user experience. 🎉
My final bits of feedback are below, after that it should be good to merge from my perspective.
Sorry, something went wrong.
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
Thanks @felixarntz. In 388be6a i introduce perflab_replace_html_entity function that change html entriey as in alert it show server’s instead of server's |
Sorry, something went wrong.
There was a problem hiding this comment.
Looks great, thanks @mukeshpanchal27!
Sorry, something went wrong.
| } | ||
| } | ||
|
|
||
| $result = activate_plugin( WP_PLUGIN_DIR . '/' . $plugin_basename ); |
There was a problem hiding this comment.
What if the plugin isn't located in WP_PLUGIN_DIR (even though this may be unlikely)? Also, the phpdoc for activate_plugin() says that this arg is relative not absolute.
Sorry, something went wrong.
There was a problem hiding this comment.
Fantastic catch! I completely overlooked that aspect. Thank you for pointing it out. I've made the necessary updates, and you can find them in the commit here: 2bd591d.
Sorry, something went wrong.
Feedback has been incorporated
| Back | FazBrowse Home | New Git URL |
Summary
Fixes #652
Relevant technical choices
Checklist