FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

try way harder on mounting sd by bani6809 · Pull Request #288 · X1Plus/X1Plus · GitHub

/ X1Plus Public

try way harder on mounting sd - #288

Open
bani6809 wants to merge 1 commit into
mainfrom
bani6809/boot-hardening
Open

try way harder on mounting sd#288
bani6809 wants to merge 1 commit into
mainfrom
bani6809/boot-hardening

Conversation

bani6809 commented Jun 8, 2024

Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

@bani6809 can we get some context on this? There's no description as to why were doing this change, and no linked GitHub issue. We need to be mindful how long we wait as flaky SDCards, while being slow to enumerate and mount, can cause other issues as well.

bani6809 commented Jun 9, 2024

Copy link
Copy Markdown
Contributor Author

@bani6809 can we get some context on this? There's no description as to why were doing this change, and no linked GitHub issue. We need to be mindful how long we wait as flaky SDCards, while being slow to enumerate and mount, can cause other issues as well.

i got this several times in a row on a samsung pro endurance. i'm pretty sure there are random timing conditions in the kernel that will cause a mount to fail that are not the fault of the card.

Copy link
Copy Markdown

@bani6809 can we get some context on this? There's no description as to why were doing this change, and no linked GitHub issue. We need to be mindful how long we wait as flaky SDCards, while being slow to enumerate and mount, can cause other issues as well.

i got this several times in a row on a samsung pro endurance. i'm pretty sure there are random timing conditions in the kernel that will cause a mount to fail that are not the fault of the card.

If I understand correctly, the SD card is mounted before the boot loader display on screen.

Possibility of corrupted file system, physical nand, or SD slot having issues?

jwise commented Jun 9, 2024

Copy link
Copy Markdown
Member

Yeah, I dunno, I'm a little worried about this one -- especially if we can't reproduce it. I think it is arguably the case that if the SD card comes up in a weird tuning state, then maybe we should just fail to boot after all, and force a reboot to try again? At least, without getting a dmesg of the failing case, I feel pretty nervous about trying to limp along in this state...

bani6809 commented Jun 9, 2024

Copy link
Copy Markdown
Contributor Author

Yeah, I dunno, I'm a little worried about this one -- especially if we can't reproduce it. I think it is arguably the case that if the SD card comes up in a weird tuning state, then maybe we should just fail to boot after all, and force a reboot to try again? At least, without getting a dmesg of the failing case, I feel pretty nervous about trying to limp along in this state...

maybe related to what balika011 suspected WRT reinit card without powercycle? https://discord.com/channels/1041781310299062282/1188616216936468542/1220843438149341184

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL