Security: Privileged API invoked via page-global window.GM_openInTab - #589
Open
tuanaiseo wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Multiple scripts call `window.GM_openInTab(...)` instead of the granted `GM_openInTab(...)`. If the page defines or overrides `window.GM_openInTab`, the userscript may execute attacker-controlled code or lose integrity of privileged actions. Affected files: GoogleTranslate-Beautification.user.js Signed-off-by: tuanaiseo <221258316+tuanaiseo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Multiple scripts call window.GM_openInTab(...) instead of the granted GM_openInTab(...). If the page defines or overrides window.GM_openInTab, the userscript may execute attacker-controlled code or lose integrity of privileged actions.
Severity: medium
File: GoogleTranslate-Beautification.user.js
Solution
Call the granted API directly (GM_openInTab) and never via window. Apply this change consistently across scripts using window.GM_openInTab.
Changes
Testing