FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: avoid deprecated urllib3 header helpers by miachillgood · Pull Request #235 · XeroAPI/xero-python · GitHub

fix: avoid deprecated urllib3 header helpers - #235

Open
miachillgood wants to merge 3 commits into
XeroAPI:masterfrom
miachillgood:codex/avoid-deprecated-urllib3-header-access
Open

fix: avoid deprecated urllib3 header helpers#235
miachillgood wants to merge 3 commits into
XeroAPI:masterfrom
miachillgood:codex/avoid-deprecated-urllib3-header-access

Conversation

Copy link
Copy Markdown

Summary

  • replace deprecated urllib3 header helper calls in RESTResponse
  • read headers through the response headers mapping instead
  • add a focused unit test for header access

Why

Fixes the deprecation warning reported in #195 when getheader() and getheaders() are called.

Testing

  • python -m pytest tests/test_api_client/test_rest_response.py

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant


Back | FazBrowse Home | New Git URL