fix(compat): avoid unconditional grpc import in v0.3 context builders - #1006
fix(compat): avoid unconditional grpc import in v0.3 context builders#1006ishymko merged 1 commit into
Conversation
Sorry, something went wrong.
There was a problem hiding this comment.
Code Review
This pull request enhances the smoke testing suite by introducing installation profiles, allowing verification that specific extras like http-server can be imported without unnecessary dependencies. Key changes include updating the Python smoke test script to support multiple profiles and adding a shell script to automate the build and installation process in clean environments using uv. Feedback highlights a potential NameError in context_builders.py due to moving the grpc import into a TYPE_CHECKING block without enabling deferred annotation evaluation, and suggests a more robust method for identifying the built wheel in the shell script.
Sorry, something went wrong.
🧪 Code Coverage (vs main)
Generated by coverage-comment.yml |
Sorry, something went wrong.
🤖 I have created a release *beep* *boop* --- ## [1.0.1](v1.0.0...v1.0.1) (2026-04-22) ### Bug Fixes * **compat:** avoid unconditional grpc import in v0.3 context builders ([#1006](#1006)) ([6b46ceb](6b46ceb)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: Ivan Shymko <ishymko@google.com>
Currently it causes no module named 'grpc' when using HTTP machinery.
Relevant "install and import" testing was extended to allow testing "extras" to catch this in the future.