Add optional FileReader to FileAPIReader. - #25
Merged
aadsm merged 1 commit intoNov 25, 2013
Merged
aadsm merged 1 commit into
aadsm merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This allows a user to set an external FileReader instance, therefore providing the ability to reuse the same FileReader instance in serial reads for better memory management.
Copy link
Copy Markdown
Owner
|
Thanks for the pull request, but I'm a bit puzzled, what other objects implement the FileReader interface? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
It's not about an implementation of FileReader interface. Every call to FileAPIReader creates a new FileReader instance and unfortunately causes a lot of memory allocation. This allows one to set an external FileReader, so that keeps memory footprint low, because every invocation of the FileAPIReader can use the same FileReader. |
Sorry, something went wrong.
aadsm
added a commit
that referenced
this pull request
Nov 25, 2013
Add optional FileReader to FileAPIReader.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows a user to set an external FileReader instance, therefore providing the ability to reuse the same FileReader instance in serial reads for better memory management.