FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Handle removing resources without parents by Mirochill · Pull Request #108 · aboutcode-org/commoncode · GitHub

Handle removing resources without parents - #108

Open
Mirochill wants to merge 1 commit into
aboutcode-org:mainfrom
Mirochill:fix-84-parentless-remove-resource
Open

Handle removing resources without parents#108
Mirochill wants to merge 1 commit into
aboutcode-org:mainfrom
Mirochill:fix-84-parentless-remove-resource

Conversation

Copy link
Copy Markdown

Summary:

  • Skip parent child-list updates when the resource parent is no longer present in the codebase.
  • Keep removing the requested resource and its descendants in that parentless case.
  • Add a regression covering removal after the parent resource is missing.

Fixes: #84

Validation:

  • git diff --check
  • git diff --check HEAD~1..HEAD
  • Not run locally

Signed-off-by: Miro <200482516+Mirochill@users.noreply.github.com>
Mirochill force-pushed the fix-84-parentless-remove-resource branch from 02cc13d to 516585b Compare May 25, 2026 19:50
Mirochill marked this pull request as ready for review May 25, 2026 19:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider that Resource.parent can be None when removing resources from the codebase

1 participant


Back | FazBrowse Home | New Git URL